elharo commented on a change in pull request #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r465334195



##########
File path: 
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##########
@@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism
    unit tests (src/test/java) but not in the model code (src/main/java).
 
  * <<system>>\
-   This scope is similar to <<<provided>>> except that you have to provide the 
JAR
-   which contains it explicitly. The artifact is always available and is not
-   looked up in a repository.
+   Maven does not add system-scoped dependencies to any classpath.

Review comment:
       The keyword is "maybe". There's no guarantee it is, and the current text 
makes it sound like this is guaranteed. The case that made me pay attention to 
this was Guava doing a complicated dance to load src.zip for use in javaDoc:
   
   ```
      <profile>
         <id>srczip-parent</id>
         <activation>
           <file>
             <exists>${java.home}/../src.zip</exists>
           </file>
         </activation>
         <dependencies>
           <dependency>
             <groupId>jdk</groupId>
             <artifactId>srczip</artifactId>
             <version>999</version>
             <scope>system</scope>
             <systemPath>${java.home}/../src.zip</systemPath>
             <optional>true</optional>
           </dependency>
         </dependencies>
       </profile>
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to