michael-o commented on a change in pull request #212:
URL: https://github.com/apache/maven-site/pull/212#discussion_r512845349
##########
File path: content/apt/guides/mini/guide-http-settings.apt
##########
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<<provider>>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
- * readTimeout: default to 1800000ms (~30 minutes) (see section <<<Read time
out>>> below)
+ * readTimeout: default to 1,800,000ms (~30 minutes) (see section <<<Read
time out>>> below)
Review comment:
` 1 800 000 ms`
##########
File path: content/apt/guides/mini/guide-http-settings.apt
##########
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<<provider>>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
Review comment:
It is somewhat incomplete:
https://github.com/apache/maven-wagon/blob/9b4f2fee4b0460aa16dee90d37a49440f09ed0db/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L286-L295
##########
File path: content/apt/guides/mini/guide-http-settings.apt
##########
@@ -88,7 +88,7 @@ the target server's authentication.
problems with HTTP servers and proxies that do not support HTTP/1.1 protocol.
-----
- Without this setting, PUT requests that require authentication will transfer
their entire payload to the server before that server
+ Without this setting, PUT requests that require authentication transfer
their entire payload to the server before that server
Review comment:
This has been on by default for quite some time:
https://github.com/apache/maven-wagon/blob/9b4f2fee4b0460aa16dee90d37a49440f09ed0db/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L963-L967
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
