Hi Karl-Heinz, thanks for the insights. I am somewhat irritated as I had you on the review list for most issues for two weeks and I even tried to ping you on slack. I wish I had had these insights before merging.
> invoker.java.version = 9-13 I tried 9+, 13- first. That did nor work for me, but oddly enough, 9-13 did. We can change it to the enumeration after the release, good idea! About this one: > invoker.toolchain.jdk.version = 11 > but I don't see a toolchains.xml file within the test There is a toolchain configuration in the github Java 8 build: https://github.com/apache/maven-jlink-plugin/blob/master/.github/workflows/maven.yml#L45-L70 It is also in jenkins: https://ci-builds.apache.org/blue/organizations/jenkins/Maven%2Fmaven-box%2Fmaven-jlink-plugin/detail/master/56/pipeline/404 All ASF Java Jenkins jobs always have toolchains configured, which is why I didn't even know about the possibility of putting a toolchains.xml file into an IT project. > I think we need to reconsider the usage of toolchains within an invoker > test or the support for toolchains in invoker... Why? If we do not test Java 8 with a toolchain, we cannot get any build. If we do not test Java 8-13 without a 14+ toolchain, we cannot verify the exception of an invalid argument. For java 9+, there is a multi release jar we need to test. etc. Summary: Due to the logic, we can never have a setup where all paths are tested! Only Java 8 + toolchain tests the non-java9-mr-jar, Only Java 9 tests the Toolprovider from the MR-jar The setup works on both jenkins and github. Not saying that they are configured perfectly, but I would not want to drop them. > furthermore the question is why is an old version of toolchains-plugin used > instead of 3.0.0 within this IT? The reason is probably simple: copy-paste. I hope that clarifies a bit. :-) Best regards, Ben Am Di., 22. Dez. 2020 um 12:49 Uhr schrieb Karl Heinz Marbaise < [email protected]>: > Hi, > > +1 from me... > > > I have found two little issues: > > I'm running with mvn -Prun-its verify > > and it shows me that the following IT's is skipped based on JRE: > > > MJLINK-41_addoptions-11/pom.xml .................. SKIPPED due to JRE > version > > I'm running on: > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: /Users/khmarbaise/tools/maven > Java version: 11.0.9, vendor: AdoptOpenJDK, runtime: > /Users/khmarbaise/.sdkman/candidates/java/11.0.9.hs-adpt > Default locale: en_GB, platform encoding: UTF-8 > OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" > > and the invoker.properties file contains: > > invoker.java.version = 9-13 > invoker.goals = clean package > invoker.buildResult = failure > > which I would expect to be running on JDK 11... but it does not. > > I have changed invoker properties file: > > invoker.java.version = 9,10,11,12,13 > > and the test will be executed... This looks like an issue in invoker > plugin... > > > Furthermore I've found an issue related to this test: > > MJLINK-36_toolchainjdk9/pom.xml .................. SKIPPED due to Toolchain > > where invoker.properties contains: > > invoker.java.version = 9+ > invoker.goals = clean install > invoker.toolchain.jdk.version = 11 > > but I don't see a toolchains.xml file within the test which means the > test is not self contained... So this means I have to configure > toolchains on my side and afterwards the IT's can be executed... I doubt > that toolchains is configured on CI?? > > > I think we need to reconsider the usage of toolchains within an invoker > test or the support for toolchains in invoker... furthermore the > question is why is an old version of toolchains-plugin used instead of > 3.0.0 within this IT? > > Kind regards > Karl Heinz Marbaise > > On 21.12.20 16:40, Benjamin Marwell wrote: > > Hi, > > > > We solved 12 issues: > > https://issues.apache.org/jira/projects/MJLINK/versions/12349376 > > > > There are three issues left in JIRA: > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MJLINK%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC%2C%20updated%20DESC > > > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1616 > > > > > https://repository.apache.org/content/repositories/maven-1616/org/apache/maven/plugins/maven-jlink-plugin/3.1.0/maven-jlink-plugin-3.1.0-source-release.zip > > > > Source release checksum(s): > > maven-jlink-plugin-3.1.0-source-release.zip sha512: > > > 021cc0e17fbb358ab52a35a9a719a47a1ae116610817d9c9f0993f2c9b065975882358bed246d5c329e8f749ef155357fcc9ef10d2814635bd8d88dd939f4182 > > > > maven-jlink-plugin-3.1.0-source-release.zip sha1: > > 4223f876848417a33fc635afd5c25e94fbd8af43 > > > > > > Staging site: > > https://maven.apache.org/plugins-archives/maven-jlink-plugin-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > >
