michael-o commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830849772
> > > General remark @michael-o : I did not made any other code change then: > > * added ProjectBuildingRequest parameter to methods, removed some unneeded members (like remote repositories). > > * removed reflection bits, replaced with direct calls > > * removed some reflection utilities, replaced with direct calls > > > My point is, that those NPE comments of your are about _old code_, I did not introduce any logic/code change in that area, and IMO we can do those later as improvement, but for now I'd leave code as is (is really just "reshuffled" into modules + changes I wrote above). I agree with that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
