MNG-5669 contains lambda and IIRC there was a follow up improvement by Guillaume.
MNG-6824 contains method references. I think both are more improvements than bugs. Before MNG-5669 Maven read a dependency that was also part of the reactor again. Result was the same, just spilling time. Before MNG-6824 the way ModelMerger was used one didn't hit the issue, but with build/consumer it did. So I don't consider these as regressions and would prefer not to take the risks of cherrypicking. Robert On 23-6-2021 19:19:44, Hervé BOUTEMY <herve.bout...@free.fr> wrote: IIUC, DefaultModelBuilder fundamental change was done on June 22 2020: https://github.com/apache/maven/commit/bdec668de9c600165bb69c95b6ea0625d9f74fb0 before that point in time, there is no issue, isn't it? then I imagine MNG-5669 and MNG-6824 are safe to cherry pick? Regards, Hervé Le mercredi 23 juin 2021, 11:10:18 CEST Robert Scholte a écrit : > I would avoid cherrypicking any commit related to the DefaultModelBuilder, > this is just not the same class anymore. Also don't try to add fixes that > has been done with Java 8 features. > > To make your life easier I would focus on regressions only. > > So I would at least NOT try to include: > - MNG-5669 > - MNG-6160 > - MNG-6824 > > Robert > > > On 23-6-2021 10:02:52, Michael Osipov wrote: > Folks, > > I'd like to proceed with 3.8.x since there are a few issues which users > would like to see addressed. > I went through the issues in 4.0.0-alpha-1 and would like to evaluate > the following to be back ported to 3.8.x branch: > > https://issues.apache.org/jira/browse/MNG-5669 > https://issues.apache.org/jira/browse/MNG-5868 > https://issues.apache.org/jira/browse/MNG-6071 > https://issues.apache.org/jira/browse/MNG-6160 > https://issues.apache.org/jira/browse/MNG-6737 > https://issues.apache.org/jira/browse/MNG-6767 > https://issues.apache.org/jira/browse/MNG-6819 > https://issues.apache.org/jira/browse/MNG-6824 > https://issues.apache.org/jira/browse/MNG-6828 > https://issues.apache.org/jira/browse/MNG-6842 > https://issues.apache.org/jira/browse/MNG-6850 > https://issues.apache.org/jira/browse/MNG-6921 > https://issues.apache.org/jira/browse/MNG-6937 > https://issues.apache.org/jira/browse/MNG-6964 > https://issues.apache.org/jira/browse/MNG-6983 > https://issues.apache.org/jira/browse/MNG-6991 > https://issues.apache.org/jira/browse/MNG-7000 > https://issues.apache.org/jira/browse/MNG-7034 > https://issues.apache.org/jira/browse/MNG-7057 > > Almost all are bugfixes. > Do you see any other issues need to be back ported? Any objects for those? > > Michael > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
