That won't work for all plugins. The jlink plugin and others are using complicated setups so they can use toolchains on GitHub Actions. It's a little bit complicated there because the plugin does work with java 8 as long as a java 9+ is configured via toolchains.
Please make sure those actions continue to work. On Sun, 19 Sep 2021, 20:22 Martin Kanters, <[email protected]> wrote: > Sounds like a great idea! > > Martin > > Op zo 19 sep. 2021 om 00:26 schreef Tamás Cservenák <[email protected]>: > > > +1 for global action > > > > T > > > > On Sat, Sep 18, 2021, 13:35 Slawomir Jaranowski <[email protected]> > > wrote: > > > > > Hi, > > > > > > Thanks for your response. I know that jenkins build is the master for > > > Apache projects, > > > but most of the projects have some GA workflows configuration which > many > > > times are different. > > > This situation generates more work for maintainer. > > > > > > Thanks to composite actions [1] we can create one global action which > has > > > defined all required steps and one action for providing configurations > > > values like jkd list, > > > both of these actions can be in one repository. > > > > > > In the rest of the project we can use those global actions, so when > next > > > time we want to change, e.g. jdk list (it changes every 6 month ;-) ) > we > > > only change it in one place. > > > This approach can make less maintenance work in maven projects. > > > > > > If you are interested let me know, I can prepare some spikes for you > and > > > provide more details. > > > > > > > > > [1] > > > > > > > > > https://docs.github.com/en/actions/creating-actions/creating-a-composite-action > > > > > > > > > sob., 18 wrz 2021 o 08:27 Martin Kanters <[email protected]> > > > napisał(a): > > > > > > > Hi Slawomir, sorry for the late reply. > > > > > > > > Great that you see the value of the workflows. > > > > I don't think there are any strict rules or guidelines around how the > > > > workflow should be configured exactly, but I think it makes sense to > > have > > > > them in place. > > > > Perhaps we should also look into a way of reusing workflows in all or > > > most > > > > of the projects (maven-core is a bit different). > > > > > > > > Just wanted to mention that for the Apache team the Apache Jenkins > > server > > > > is what matters most. GA are helpful for contributors and committers > > > > working via PRs, but in the end Apache Jenkins has to pass before a > > merge > > > > is allowed. Hence, I think we should go for a reasonable workflow > > > > configuration, it does not have to be more extensive than the Jenkins > > > > setup. Still, having macOS builds is very useful, Jenkins does not > have > > > > that AFAIK. > > > > > > > > Martin > > > > > > > > > > > > > > > > > > > > Op za 11 sep. 2021 om 20:43 schreef Slawomir Jaranowski < > > > > [email protected]>: > > > > > > > > > Hi, > > > > > > > > > > Many of maven, maven plugins projects have GutHub Action build > > > > configured. > > > > > It is very useful for contributors - we can verify PR early, > > especially > > > > on > > > > > many different operating systems - which can't be done locally, or > is > > > > more > > > > > complicated. > > > > > > > > > > Most of workflows have define build matrix like: > > > > > > > > > > matrix: > > > > > os: [ubuntu-latest, windows-latest, macOS-latest] > > > > > java: [8, 11, 16, 17-ea] > > > > > > > > > > But some have: > > > > > > > > > > matrix: > > > > > os: [ubuntu-latest, windows-latest, macOS-latest] > > > > > java: [8, 11, 16, 17-ea] > > > > > jdk: [adopt, zulu] > > > > > > > > > > > > > > > Question: > > > > > > > > > > Are there some guidelines about how GitHub Action should be > > configured? > > > > > If no guidelines, which build matrix will be the most expected? > > > > > > > > > > I ask in conjunction to > > > https://issues.apache.org/jira/browse/MDEP-768 > > > > > > > > > > > > > > > -- > > > > > Sławomir Jaranowski > > > > > > > > > > https://twitter.com/SlawekJaran > > > > > https://github.com/slawekjaranowski > > > > > https://linkedin.com/in/slawomirjaranowski > > > > > > > > > > > > > > > > > > -- > > > Sławomir Jaranowski > > > > > >
