Please don't change the default behavior to exclude test sources! Non-binding -1 from me.
Some tests serve as nice examples. I also want to enforce checkstyle for PR sources consistently whether the changes are in main or test. Please don't accepting this as is and make me edit dozens and dozens of POMs. Gary On Sat, May 20, 2023, 11:12 Elliotte Rusty Harold <[email protected]> wrote: > https://github.com/apache/maven-checkstyle-plugin/pull/76 is in > progress from an external developer and is, IMHO, a quite nice > improvement. Might be worth waiting for this to be finished up. > > Otherwise, I found some minor issues in dependencies and the tests, > but nothing blocking. > > On Fri, May 19, 2023 at 1:49 PM Michael Osipov <[email protected]> > wrote: > > > > Hi, > > > > we solved 4 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&version=12353164 > > > > There are still a couple of issues left in JIRA: > > > https://issues.apache.org/jira/issues/?jql=project+%3D+MCHECKSTYLE+AND+resolution+%3D+Unresolved > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1946/ > > > https://repository.apache.org/content/repositories/maven-1946/org/apache/maven/plugins/maven-checkstyle-plugin/3.3.0/maven-checkstyle-plugin-3.3.0-source-release.zip > > > > Source release checksum(s): > > maven-checkstyle-plugin-3.3.0-source-release.zip > > sha512: > > > c27aa2dbc287764e097ab044a2780fc52e1afcf4a00a93793156df285f6595ed327fca1638a566c7673b3221dd2b98ee4d6ff54d1e93c5963f95ea0f58018067 > > > > Staging site: > > > https://maven.apache.org/plugins-archives/maven-checkstyle-plugin-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > -- > Elliotte Rusty Harold > [email protected] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
