Am 2023-12-31 um 22:02 schrieb Maarten Mulders:
On 31/12/2023 21:58, Michael Osipov wrote:
Am 2023-12-31 um 21:33 schrieb Maarten Mulders:
Here's (my) last vote of the year: +1
- Maarten
PS. I noticed that with this release, both Surefire and Failsafe
start spitting out an extra message into the output that is not there
in 3.2.3:
[INFO] --- surefire:3.2.4:test (default-test) @ marky ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
ShellCommandline: [/bin/sh, -c, cd '<working-directory>' &&
'<path-to-java-executable>' '-jar'
'<working-directory>/target/surefire/surefirebooter-20231231212637775_3.jar' '<working-directory>/target/surefire' '2023-12-31T21-26-37_700-jvmRun1' 'surefire-20231231212637775_1tmp' 'surefire_0-20231231212637775_2tmp']
I'm not really happy with this - I prefer my build logs to be short &
sweet and I feel this adds noise. But I do not consider it a reason
to cast a negative vote.
What you see is the result of:
D:\Entwicklung\Projekte\maven-shared-utils
[(maven-shared-utils-3.3.4) +0 ~1 -0 !]> git diff -w -U0
diff --git
a/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
b/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
index e03e905c2..b4ae25f66 100644
--- a/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
+++ b/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
@@ -396,0 +397,2 @@ public class Commandline
+ String[] cl = getShellCommandline();
+ System.out.println( "ShellCommandline: " +
Arrays.toString( cl ) );
@@ -399 +401 @@ public class Commandline
- process = Runtime.getRuntime().exec(
getShellCommandline(), environment );
+ process = Runtime.getRuntime().exec( cl, environment );
@@ -414 +416 @@ public class Commandline
- process = Runtime.getRuntime().exec(
getShellCommandline(), environment, workingDir );
+ process = Runtime.getRuntime().exec( cl,
environment, workingDir );
my local testing, but that should not arrive on your side. That is why
I am very confused about this...
I will try with a fesh local repo as well...
I downloaded the JARs only tonight, so I'm afraid it must be in the
release. But for good measure, I deleted
~/.m2/repository/org/apache/maven/surefire and tried again. The
additional output is indeed still there...
Found it:
[INFO] --- maven-shade-plugin:3.5.1:shade (default) @ surefire-shared-utils ---
[INFO] Including org.apache.maven.shared:maven-shared-utils:jar:3.3.4 in the
shaded jar.
[INFO] Including commons-io:commons-io:jar:2.15.0 in the shaded jar.
[INFO] Including org.apache.commons:commons-lang3:jar:3.14.0 in the shaded jar.
[INFO] Including org.apache.commons:commons-compress:jar:1.25.0 in the shaded
jar.
[INFO] Dependency-reduced POM written at: D:\Entwicklung\Projekte\Maven
Surefire\surefire-shared-utils\dependency-reduced-pom.xml
My locally modified version is shaded into Surefire. I will need to
reroll. Thanks for testing...
