Hi Eliotte, Is the -1 only motivated by the fact there is a PR opened?
If so please consider two things: * it is always the case for most releases (maven, asf, living projects ;)) so not sure when it became a hard criteria but if so we should probably think to be more open if we want to release a day * If you take time to review the PR you mention you will also see it just revert a fix and that the final code should be more complex if it lands in shade plugin a day - there are always workarounds there - so don't think we can make it in the week so can await another round and way more time to make it right (long story sort shade has an old bug where it mixes the same config for different kind of rewritten sources, while it often works and stays simple, it also makes it insanely hard to be right since you don't know what you rewrite - a variable, a package, a class name, ...) Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le dim. 18 févr. 2024 à 14:30, Elliotte Rusty Harold <elh...@ibiblio.org> a écrit : > -1 > > https://github.com/apache/maven-shade-plugin/pull/193 from an external > contributor is open and unreviewed, although it seems to meet the > criteria for merging if it's correct. It's helpful to triage open PRs > and issues before cutting a release. > > On Sat, Feb 17, 2024 at 1:01 PM Hervé Boutemy <herve.bout...@free.fr> > wrote: > > > > Hi, > > > > We solved 6 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12352505&styleName=Text > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-2065/ > > > https://repository.apache.org/content/repositories/maven-2065/org/apache/maven/plugins/maven-shade-plugin/3.5.2/maven-shade-plugin-3.5.2-source-release.zip > > > > Source release checksum(s): > > maven-shade-plugin-3.5.2-source-release.zip sha512: > 23fcd21e6b915114efa133b1c4e46fa0b3d77874ff9d974e4bdb24940ea0ed9b7ffaf7f3d1e8a8549837cfe1de7ff2fc8ae7fc68bfc0477ea7a4b8b53e42f6f7% > > > > Staging site: > > https://maven.apache.org/plugins-archives/maven-shade-plugin-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- > Elliotte Rusty Harold > elh...@ibiblio.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
