* don't You are right that spotless will not touch files if you are unable to parse it.
So let's try. S. pt., 29 lis 2024, 22:16 użytkownik Guillaume Nodet <gno...@apache.org> napisał: > Do or don’t ? > Wdym “breaking it” ? > If the code cannot be parsed, the formatted will simply fail (and fail the > build btw), so it won’t modify it. > > ------------------------ > Guillaume Nodet > > > > Le ven. 29 nov. 2024 à 21:52, Sylwester Lachiewicz <slachiew...@gmail.com> > a écrit : > > > I do think that's a good idea as it will always format code that may not > > yet committed. Potentially breaking it > > > > Sylwester > > > > pt., 29 lis 2024, 21:10 użytkownik Guillaume Nodet <gno...@apache.org> > > napisał: > > > > > Created the following PR which should work (still to be tested): > > > > > > https://github.com/apache/maven-parent/pull/215 > > > > > > Le ven. 29 nov. 2024 à 18:21, Elliotte Rusty Harold < > elh...@ibiblio.org> > > a > > > écrit : > > > > > > > While working on a third party plugin I noticed it was configured to > > > > autorun spotless as part of "mvn test" (and probably other goals): > > > > > > > > [INFO] --- spotless:2.43.0:apply (default) @ spotbugs-maven-plugin > --- > > > > [INFO] Spotless.Format is keeping 10 files clean - 0 were changed to > > > > be clean, 0 were already clean, 10 were skipped because caching > > > > determined they were already clean > > > > [INFO] Spotless.Format is keeping 182 files clean - 0 were changed to > > > > be clean, 1 were already clean, 181 were skipped because caching > > > > determined they were already clean > > > > [INFO] > > > > > > > > We should do that too in our poms to avoid the recurring and annoying > > > > problems of forgetting to run spotless manually and consequently > > > > having a meaningless break in the CI that needs to be investigated. > > > > Integrated over all of us this should save a few days of developer > > > > time per year. > > > > > > > > I'd file a bug, but the way we've set up issue tracking this would be > > > > one per repo, and I'm disinclined to file the same bug 40 times. > Let's > > > > just do it. > > > > > > > > -- > > > > Elliotte Rusty Harold > > > > elh...@ibiblio.org > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > > > -- > > > ------------------------ > > > Guillaume Nodet > > > > > >
