Hey Maven folks,

I wanted to raise concerns about a breaking change made in the 3.3.0 release of 
the maven-release-plugin

This change was suggested in 
https://github.com/apache/maven-release/issues/1422 and provided in PR 
https://github.com/apache/maven-release/pull/1423

Despite several well-founded objections to this idea being made in the original 
issue, and the PR, these were dismissed by the OP (a Maven PMC member AFAICT) 
and this change was merged with seemingly minimal discussion or consideration 
of its impacts on the many developers who depend on Maven for their builds.

If you weren’t already aware this breaking change adds the "[ci skip]” text 
snippet into the commit message that the release plugin makes for the release 
commit, i.e. the SCM commit that has the non-SNAPSHOT version set and is tagged 
with the release tag.  The effect of this text is that most common CI/CD 
systems ignore this commit and don’t build it.
However, many developers and organisations, myself included, have designed 
their CI/CD workflows around triggering release workflows from the release 
commit which this change breaks.  Forcing us either to change our plugin 
configuration back to the old commit message default, or rollback to an earlier 
plugin version.

Why was a breaking change of this magnitude not raised on the developers list 
and discussed more widely?

This is in fact the second maven-release-plugin release in a row that has been 
unusable for us (we were also affected by the 
https://github.com/apache/maven-release/issues/1420 bug) so it feels like the 
release plugin isn’t really getting the care and attention it should, given how 
pivotal a plugin it is for Maven users (and presumably other Maven plugins?).

Note I have proposed a PR to revert this change - 
https://github.com/apache/maven-release/pull/1445

Note I’ve been around the ASF a fair while and I’m well aware that working on a 
tooling/library project like Maven is a fairly thankless task.  Thank you for 
all the hard work you do to keep this awesome project going!  I will be trying 
to keep an eye on this mailing list going forward and aim to test and vote on 
plugin releases where possible so that issues like this can hopefully be 
discussed before they make it out into the wild rather than after the fact in 
future.

Best Regards,

Rob Vesse

Reply via email to