The following comment has been added to this issue:
Author: Chad Brandon
Created: Wed, 30 Jun 2004 2:09 PM
Body:
One more check needs to be added to the file I attached in my last comment, in this
section below, you'll see I've added a check for "or aspectSourceDir == ''" to the
<j:if> tag (where aspectSourceDir is pom.build.aspectSourceDirectory).
This needs to be here, or else the aspectLibraryPresent property will never be set to
true (when there is no pom.build.aspectSourceDirectory defined in the POM), since as
I've said in my previous comments aspectSourcesPresent will be true in this case.
<!-- If there aren't aspect sources check if there are aspect libraries -->
<j:if test="${aspectSourcesPresent == null or aspectSourceDir == ''}">
<j:forEach var="artifact" items="${pom.artifacts}">
<j:set var="dep" value="${artifact.dependency}"/>
<j:if test="${dep.getProperty('aspectj.weaveWith')=='true' and
dep.type=='jar'}">
<j:set var="aspectLibrariesPresent" value="true"/>
<j:break/>
</j:if>
<j:if test="${dep.getProperty('aspectj.weaveInto')=='true' and
dep.type=='jar'}">
<j:set var="aspectLibrariesPresent" value="true"/>
<j:break/>
</j:if>
</j:forEach>
</j:if>
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPASPECTJ-11?page=comments#action_21209
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPASPECTJ-11
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPASPECTJ-11
Summary: aspectj:test-compile goal should check for
pom.build.unitTestSourceDirectory
Type: Bug
Status: Open
Priority: Major
Original Estimate: 10 minutes
Time Spent: Unknown
Remaining: 10 minutes
Project: maven-aspectj-plugin
Versions:
3.1
Assignee: Carlos Sanchez
Reporter: Chad Brandon
Created: Wed, 30 Jun 2004 10:43 AM
Updated: Wed, 30 Jun 2004 2:09 PM
Environment: maven-1.0-rc4
Description:
The aspectj plugin should check for the presence of the unit test
source directory before calling aspectj:compile. This is useful in cases where you
want to define your preGoal in your subproject's maven.xml and subprojects don't have
any tests defined. Otherwise you'll get a error telling you the
'maven.test.compile.src.set' property doesn't exist. This is easy to add, just add the
following check to the aspectj:test-compile goal:
<j:set var="testSourceDir" value="${pom.build.unitTestSourceDirectory}"/>
<ant:available
property="hasTestDir"
file="${testSourceDir}"/>
<j:if test="${shouldWeave == 'true' and hasTestDir != null and testSourceDir !=
''}">
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
