The following comment has been added to this issue:

     Author: Dennis Lundberg
    Created: Tue, 27 Jul 2004 7:19 PM
       Body:
1. Separate the scm reports from the xdoc plugin:

OK, I have managed to get the SCM plugin to register, create the report and 
deregister. The problem I have now is that this really isn't a "report", it is a 
"Project Info" menu item in the navigation. But I now have it under "Project Reports" 
instead. What can be done about that? Do we need a mechanism in the xdoc-plugin to 
register such items as well as reports?

2. Keep the gleaning of CVS info out of the org.apache.maven.project.Repository class:

I thought about this some more and came to the same conclusion as you, with regards to 
using a factory class in the SCM plugin. We should also keep o.a.m.project.Repository 
clean of any cvs-specific methods. But I still think that we need getScmType() and 
getDeveloperScmType() in there. At least for the now. Do you agree?

getDeveloperScmType() is missing right now. One of the fixes for this issue requires 
it. My patch Repository.java.patch fixes it. Should I open an issue for this in Maven 
instead of keeping it in this plugin? 

Beeing new to the maven developer comunity I don't know how the workload between maven 
and the plugins is divided. Are there different developers working on maven than on 
the plugins, or do you work all over the place?
---------------------------------------------------------------------
View this comment:
  http://jira.codehaus.org/browse/MPXDOC-114?page=comments#action_22418

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPXDOC-114

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPXDOC-114
    Summary: cvs-usage presumes pserve protocol on <connection>
       Type: Bug

     Status: Open
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-xdoc-plugin

   Assignee: Jason van Zyl
   Reporter: Erik Husby

    Created: Wed, 7 Jul 2004 4:10 PM
    Updated: Tue, 27 Jul 2004 7:19 PM

Description:
The Repository report makes some assumptions about ones use of cvs that are not 
necessarily true.

1. The pom.repository.connection is assumed to be the pserve protocol. Not true for 
our in-house projects.

2. The pom.repository.developerConnection is only displayed when there is a 
pom.repository.connection entry. The two fields are not connected.

3. The CVS Access behind firewall is always included if pom.repository.connection is 
specified. This is not true in our in-house environment.

The changelog report works fine if only pom.repository.developerConnection is 
specified, I would like to not specify pom.repository.connnection


Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.

Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in 
velocity, I could not see why problem #2 occurs.

Problem#3 can be solved in a number of ways from an addition to the pom.repository or 
by an additional maven-xdoc-plugin property.




---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to