Wow... If it's easy, I say go for it.. There are a lot of situations where plugins call test:compile, java:compile, and other well known goals just to ensure that the step happened.. I can see this attribute being very useful..
Can you share what types of backwards compatibility affects this would really have..? I can't really think of any.. It would be nice for 1.1... Wait, scratch that.. You're on holiday till the 16th! Eric > -----Original Message----- > From: Brett Porter [mailto:[EMAIL PROTECTED] > Sent: Saturday, July 31, 2004 4:12 PM > To: Maven Developers List > Subject: RE: Avoid running multiple goals (was: RE: issue w/ test:test > goal being run multiple times when dist goal is executed) > > > There is an issue in JIRA for this. it is really easy for me to > enable this feature, but it breaks > existing builds. If we can sacrifice backwards compat., then I'm > happy to do it. > > It already works for prereqs. > > I was actually thinking it would be better to add an attribute to > the attainGoal that > defaulted to false for backwards compat, but when set to true > made sure it didn't run again. > We can do that in 1.1 if wanted. > > m2 does it completely differently and it is not an issue. There > is actually a defined lifecycle :) > > - Brett > > Quoting "March, Andres" <[EMAIL PROTECTED]>: > > > I am also confused as to how goals are determined to be run. I > thought it > > would be like ant where a goal would only be run once. Could > someone explain > > how this is possible and if not why? > > > > > -----Original Message----- > > > From: Carlos Sanchez [mailto:[EMAIL PROTECTED] > > > Sent: Friday, July 30, 2004 12:03 PM > > > To: 'Maven Users List'; [EMAIL PROTECTED]; 'Maven Developers List' > > > Subject: Avoid running multiple goals (was: RE: issue w/ > test:test goal > > > being run multiple times when dist goal is executed) > > > > > > I personally run site with junit, clover and jcoverage > reports and would > > > be > > > difficult to skip test:test. > > > > > > I see it more a general question for all plugins. Maven > should keep track > > > of > > > goals run and don't run again them. Plugins should be able to override > > > that, > > > e.g. clover could set test:test as "not run". > > > > > > I don't know if this was thought for next releases and m2, can anyone > > > tell? > > > > > > I'll move this discussion to developer list. > > > > > > Regards > > > > > > Carlos Sanchez > > > A Coruņa, Spain > > > > > > Oness Project > > > http://oness.sourceforge.net > > > > > > > > > > -----Original Message----- > > > > From: Eric Pugh [mailto:[EMAIL PROTECTED] > > > > Sent: Friday, July 30, 2004 6:41 PM > > > > To: Carlos Sanchez; 'Maven Users List' > > > > Subject: RE: issue w/ test:test goal being run multiple times > > > > when dist goal is executed > > > > > > > > Yeah, I'm actually thinking that the pregoal would be the way > > > > to go.. But, I see it as something you configure your > > > > project.. for example, if you want the tests to run, but you > > > > need to do the bytecode manipulation, then set the preGoal to > > > > set maven.test.skip=true after running once, and have clover > > > > or jcoverage run first.. > > > > > > > > If you run either first, and then run the junit report, it > > > > doesn't have to > > > > run the test:test again... What clover or jcoverage output > > > > has everything > > > > the report needs.. > > > > > > > > Eric > > > > > > > > > -----Original Message----- > > > > > From: Carlos Sanchez [mailto:[EMAIL PROTECTED] > > > > > Sent: Friday, July 30, 2004 5:44 PM > > > > > To: 'Maven Users List'; [EMAIL PROTECTED] > > > > > Subject: RE: issue w/ test:test goal being run multiple times when > > > > > dist goal is executed > > > > > > > > > > > > > > > Hi, > > > > > > > > > > Just be sure that it does't break plugins that need to > > > > rerun test:test > > > > > as clover or jcoverage. > > > > > > > > > > Regards > > > > > > > > > > Carlos Sanchez > > > > > A Coruņa, Spain > > > > > > > > > > Oness Project > > > > > http://oness.sourceforge.net > > > > > > > > > > > -----Original Message----- > > > > > > From: Eric Pugh [mailto:[EMAIL PROTECTED] > > > > > > Sent: Friday, July 30, 2004 5:41 PM > > > > > > To: Maven Users List > > > > > > Subject: RE: issue w/ test:test goal being run multiple > > > > times when > > > > > > dist goal is executed > > > > > > > > > > > > I've seen the same thing, and actually thought about some > > > > > > fixes.. Could > > > > > > make junit-report smarter to only run if the unit test > > > > report files > > > > > > don't exist. Could also introduce some sort of pregoal > > > > to test:test > > > > > > that checks and if the tests have been run, then set > > > > > > maven.test.skip=true.. > > > > > > > > > > > > Eric > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Springer, Ian P. [mailto:[EMAIL PROTECTED] > > > > > > > Sent: Monday, July 26, 2004 6:48 PM > > > > > > > To: [EMAIL PROTECTED] > > > > > > > Subject: issue w/ test:test goal being run multiple times when > > > > > > > dist goal is executed > > > > > > > > > > > > > > > > > > > > > When I run "maven dist", my project's unit tests get run > > > > > > three times: > > > > > > > > > > > > > > 1) because test:test is a prereq of jar:jar > > > > > > > 2) because test:test is a prereq of war:webapp > > > > > > > (which I call from a dist:prepare-bin-filesystem postgoal in > > > > > > > maven.xml) > > > > > > > 3) because junit-report:report does an attainGoal of test:test > > > > > > > > > > > > > > Running the unit test three times slows down the dist build > > > > > > and also > > > > > > > clutters Maven's output. Does anyone know of a > > > > workaround for this > > > > > > > issue? > > > > > > > > > > > > > > Thanks, > > > > > > > Ian > > > > > > > > > > > > > > > > > > > > > > > > -------------------------------------------------------------------- > > > > > > - > > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > -------------------------------------------------------------------- > > > > > > - To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
