The following comment has been added to this issue:
Author: Vincent Massol
Created: Sat, 7 Aug 2004 12:17 PM
Body:
Felipe,
I've not tried to apply the patch yet because I have a few questions on the patch code
below:
<j:if test="${size(pom.versions)!=0}">
<j:set var="foundTag" value="false"/>
<j:forEach var="version" items="${pom.versions}">
<j:if test="${version.id==versionVariable}">
<j:set var="found" value="true"/>
</j:if>
</j:forEach>
<j:if test="${!found}">
Several comments:
1/ SNAPSHOT versions should *NOT* be defined in the <versions> tag. Only released
version. Thus if current version is a snapshot version I'm not sure your patch will do
the correct thing. But then I may be wrong as I'm not sure I fully understand it...
2/ What is foundTag variable for? It doesn't seem to be used
3/ There's no point in iterating once found is true, right? Thus there should probably
be a <j:break/> tag
Thanks
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPANNOUNCEMENT-14?page=comments#action_22841
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPANNOUNCEMENT-14
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPANNOUNCEMENT-14
Summary: [PATCH] Check if there is a SCM tag set for the project
Type: Improvement
Status: Open
Priority: Trivial
Original Estimate: 10 minutes
Time Spent: Unknown
Remaining: 10 minutes
Project: maven-announcement-plugin
Versions:
1.3
Assignee: Vincent Massol
Reporter: Felipe Leme
Created: Tue, 3 Aug 2004 1:48 PM
Updated: Sat, 7 Aug 2004 12:17 PM
Description:
As I mentioned earlier in the dev-list, if the POM defines a <versions> element, than
the current version should have an equivalent <version> there, otherwise check-version
should fail.
If that happens, announcement:check-version will show this message:
Current release (XXX) does not have an entry at the POM's versions element.
-- Felipe
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
