brett       2004/11/05 23:52:48

  Modified:    src/java/org/apache/maven/plugin Tag: MAVEN-1_0-BRANCH
                        PluginManager.java
  Log:
  we should install to the user plugins directory for this, otherwise 
plugin:install-now doesn't work properly
  
  Revision  Changes    Path
  No                   revision
  No                   revision
  1.70.4.58 +2 -4      maven/src/java/org/apache/maven/plugin/PluginManager.java
  
  Index: PluginManager.java
  ===================================================================
  RCS file: /home/cvs/maven/src/java/org/apache/maven/plugin/PluginManager.java,v
  retrieving revision 1.70.4.57
  retrieving revision 1.70.4.58
  diff -u -r1.70.4.57 -r1.70.4.58
  --- PluginManager.java        6 Nov 2004 07:31:13 -0000       1.70.4.57
  +++ PluginManager.java        6 Nov 2004 07:52:47 -0000       1.70.4.58
  @@ -834,8 +834,6 @@
       {
           // By default, don't copy to the unpacked plugins directory - only use this 
dependency for this project
           installPlugin( file, parentProject, false );
  -        // TODO:  we should unload the plugin after the project is done in this 
case - we really need
  -        // to define the lifecycle of plugins
       }
   
       /**
  @@ -843,7 +841,6 @@
        *
        * @param file          the file to install. Must be a plugin jar
        * @param parentProject the project to load the installed plugin into
  -     * @todo remove any old one
        */
       public void installPlugin( File file, Project parentProject, boolean cache )
           throws MavenException
  @@ -894,6 +891,7 @@
                   housing.parse( mapper );
                   if ( cache )
                   {
  +                    FileUtils.copyFileToDirectory( file, userPluginsDir );
                       cacheManager.registerPlugin( pluginName, housing );
                       housing.parse( cacheManager );
                       cacheManager.saveCache( unpackedPluginsDir );
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to