The following comment has been added to this issue:
Author: Felipe Leme
Created: Tue, 16 Nov 2004 2:14 PM
Body:
Charles,
Your patch seems to be fine, but as dIon commented, we need the documentation
and test cases too (if you don't provide these, we need to create them by
ourselves, which in turns delays fixing this issue).
The documentation is pretty easy: you just need to udpate the
xdocs/properties.xml file (you can also change project.xml to add yourself as
contributor and xdocs/changes.xml with this issue, if you prefer). The testcase
is a little bit trickier, so here is a sample script:
1.Create the directory src/plugin-tests/test06. I will refer to this directory
as the testcase directory
2.Add a new project.properties on the new directory contain the common
properties for all testcases (in this case, I would say
maven.ear.appxml.generate=true)
3.Copy the project.xml from another testcase (for instance, test05) and change
the proper settings (testcase description, your info, etc...)
4.Then you need to create the maven.xml with the testcase. In this case, I
would suggest 4 testcases, 2 for each new propertie: 1 for the case where the
property is set; 1 for the case where it is not. A good example on how to
create multiple tests in just one maven.xml is the testcase for the hibernate
plugin
5.Regarding the tests themself, they consist of generating the EAR, extracting
the application.xml and verifying that the expected elements are there (using
XPath).
If you have any more doubts, please let us know (through this issue).
-- Felipe
PS: please provide a new patch with everything then
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPEAR-17?page=comments#action_26486
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPEAR-17
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPEAR-17
Summary: plugin could generate more elements in application.xml
Type: Improvement
Status: Unassigned
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-ear-plugin
Assignee:
Reporter: Charles Crouch
Created: Fri, 25 Jun 2004 4:25 PM
Updated: Tue, 16 Nov 2004 2:14 PM
Environment: maven-ear-plugin-1.5, maven-1.0-rc3, windows XP SP1
Description:
The EAR plugin can generate an application.xml containing display-name and
module elements but it lacks several others, i.e.
1) application/description
2) application/security-role/role-name
The changes described below are quite small and enable the creation of the
above elements by specifying more properties, e.g.
1) maven.ear.appxml.description=Product ${pom.groupId}, version
${pom.currentVersion}
2) maven.ear.appxml.securityRoles=UserRole, AdminRole
The changes to the plugin.jelly, positioned correctly, would be:
1) <j:set var="applicationDescription"
value="${maven.ear.appxml.description}"/>
<j:if test="${!empty(applicationDescription)}">
<x:element
name="description">${maven.ear.appxml.description}</x:element>
</j:if >
2) <j:set var="securityRoles" value="${maven.ear.appxml.securityRoles}"/>
<j:if test="${!empty(securityRoles)}">
<util:tokenize var="roles" delim=","
trim="true">${maven.ear.appxml.securityRoles}</util:tokenize>
<j:forEach var="role" items="${roles}">
<x:element name="security-role">
<x:element
name="role-name">${role.trim()}</x:element>
</x:element>
</j:forEach>
</j:if >
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
