Dion Gillard wrote:
On Sun, 16 Jan 2005 15:16:24 -0500, Phil Steitz <[EMAIL PROTECTED]> wrote:

Dion Gillard wrote:

I'd think the preferred approach is to use resources for including
files in the jar. If this is not working correctly and consistently,
let's work to fix it.

This works fine. The only inconsistency is that LICENSE.txt is included automatically by the jar plugin, but the ant plugin does not generate code to include it.


I'll take a look at MPANT-23 and see if it's ok to apply.

Thanks. I was confused about where to find the license file when I submitted the patch. I will submit an updated patch with the right file spec.



Does anyone have objections to including the LICENSE file in the Ant build?


The other issue is the files added to top-level directories of the
tarballs by the dist plugin. Now this is hard-coded. It would be
convenient to be able to specify other / additional files to include
somehow.


By hard-coded do you mean it's coded in maven.xml as a pre or post goal?

Its hard-coded in the dist plugin, e.g.:

<ant:copy todir="${maven.dist.bin.assembly.dir}">
  <ant:fileset dir=".">
    <ant:include name="README.txt"/>
    <ant:include name="LICENSE*"/>
  </ant:fileset>
</ant:copy>

Similar for source distro. To add other stuff, you need to use maven.xml (unless I am missing something).

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to