[ http://jira.codehaus.org/browse/MNG-478?page=comments#action_44281 ] 

Greg Case commented on MNG-478:
-------------------------------

After using Maven2 for sometime (and loving it), I would like to help out by 
taking a crack at submitting a patch for this issue, but wanted to get some 
ideas of how to aproach it before I start hacking away...    Currently the 
WarMojo is using  FileUtils.copyDirectoryStructure from plexus, which of course 
doesn't support excludes/includes.  

I was thinking of modifying this to use an approach similar to how 
ResourcesMojo handles the copying, by using DirectoryScanner and setting the 
excludes/includs there.   So my questions are:

1)  Is this an appropriate approach?

2)  Does it make sense to allow for multiple <warSourceExcludes> elements, 
rather than a single element with a comma-separated list?  It would seem that 
multiple elements would be cleaner, and more consistent with the rest of the 
maven 2 project.



> war:war warSourceExcludes parameter not used when set in the POM
> ----------------------------------------------------------------
>
>          Key: MNG-478
>          URL: http://jira.codehaus.org/browse/MNG-478
>      Project: Maven 2
>         Type: Bug
>   Components: maven-plugins
>     Versions: 2.0-alpha-2
>  Environment: Windows XP
>     Reporter: Yann Le Du
>      Fix For: 2.0-beta-1

>
>
> I got the following in my POM for a WAR-packaged project :
>   <build>
>     <plugins>
>       <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-war-plugin</artifactId>
>         
>         <configuration>
>           <warSourceExcludes>**/test.html</warSourceExcludes>
>         </configuration>
>       </plugin>
>     </plugins>
>   </build>
> I run "m2 install". The file src/main/webapp/test.html is included in the 
> resulting WAR, but, unless I'm mistaken, it shouldn't.
> I've tried with the following patterns :
> test.html
> */test.html
> **/test.html
> *\test.html
> **\test.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to