[ http://jira.codehaus.org/browse/MPSIMIAN-12?page=comments#action_44961 ] 

Jim Dickinson commented on MPSIMIAN-12:
---------------------------------------

I have this problem also... all of the links contain 'xref-test' where they 
should only contain 'xref'...

The problem appears to be somewhere in these lines of simian.jsl (96-136)...

<j:forEach var="duplicationArea" items="${blocks}">

                        <j:set var="name" 
value="${duplicationArea.attribute('sourceFile').getValue()}"/>

                        <j:set var="srcDirLength" value="${srcDir.length() + 
1}"/>

                        <j:set var="testDirLength" value="${testDir.length() + 
1}"/>

                        <j:set var="testIndex" 
value="${name.lastIndexOf(testDir)}"/>

                        <j:choose>

                          <j:when test="${testIndex > 0}">

                                <j:set var="name" 
value="${name.substring(mavenTool.toInteger(testDirLength.toString()))}"/>

                          </j:when>

                          <j:otherwise>

                                <j:set var="name" 
value="${name.substring(mavenTool.toInteger(srcDirLength.toString()))}"/>

                          </j:otherwise>

                        </j:choose>

                        <j:set var="lastIndex" 
value="${name.lastIndexOf('.java')}"/>



                        <j:choose>

                          <j:when test="${lastIndex > 0}">

                            <j:set var="index" 
value="${mavenTool.toInteger(lastIndex.toString())}"/>

                            <j:set var="nameWithoutJavaExtension" 
value="${name.substring(0, index)}"/>

                            <util:replace var="nameWithoutJavaExtension" 
value="${nameWithoutJavaExtension}" oldChar="\\" newChar="/"/>

                                <j:choose>

                                  <j:when test="${testIndex > 0}">

                                    <li><a 
href="xref/${nameWithoutJavaExtension}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension}
 ( ${duplicationArea.attribute('startLineNumber').getValue()} - 
${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>

                                  </j:when>

                                  <j:otherwise>

                                    <li><a 
href="xref-test/${nameWithoutJavaExtension}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension}
 ( ${duplicationArea.attribute('startLineNumber').getValue()} - 
${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>

                                  </j:otherwise>

                                </j:choose>

                          </j:when>

                          <j:otherwise>

                                <j:choose>

                                  <j:when test="${testIndex > 0}">

                                    <li><a 
href="xref/${name}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension}
 ( ${duplicationArea.attribute('startLineNumber').getValue()} - 
${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>

                                  </j:when>

                                  <j:otherwise>

                                    <li><a 
href="xref-test/${name}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension}
 ( ${duplicationArea.attribute('startLineNumber').getValue()} - 
${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>

                                  </j:otherwise>

                                </j:choose>

                          </j:otherwise>

                        </j:choose>

                  </j:forEach>

This is with the released 1.5 simian plug-in. It looks like the logic is wrong, 
or testIndex is not being set correctly (i.e. true when it should be false).

> Simian report contains broken links
> -----------------------------------
>
>          Key: MPSIMIAN-12
>          URL: http://jira.codehaus.org/browse/MPSIMIAN-12
>      Project: maven-simian-plugin
>         Type: Bug
>  Environment: Maven 1.0, Java 1.4.2, all platforms.
>     Reporter: Ricardo Gladwell

>
>
> Reports generated through the simian maven plugin contain broken links for 
> all entries in the "duplications" section. Please see simian report on my 
> site:
> http://jexus.sourceforge.net/simian-report.html
> I have seen this in other maven project sites with simian reports.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to