I agree with Vincent. I don't think we should be working around bugs in the beta by changing the plugins (esp in breaking backwards compat)
Cheers, Brett Vincent Massol wrote: >Hi Arnaud, > >A pity... It took me a while to move from the reactor to using the >multiproject plugin and now we're back again to square one... :-) > >Not that I care that much but I'm curious to understand if we have changed >our m1 vision (which was to reuse existing plugins as much as possible). >Here we are now duplicating code from the multiproject plugin. > >Also it's dangerous as before a user could use all the available >multiproject properties to configure the plugins whereas now they are >limited to the ones you've defined as attributes of the reactor tag. > >Thanks >-Vincent > > > >>-----Original Message----- >>From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] >>Sent: mercredi 14 septembre 2005 16:07 >>To: [EMAIL PROTECTED] >>Subject: svn commit: r280860 - in /maven/maven-1/plugins/trunk: ./ >>abbot/src/plugin-test/ clover/src/plugin-test/ cruisecontrol/src/plugin- >>test/ dashboard/src/plugin-test/ eclipse/src/plugin-test/ >> >>Author: aheritier >>Date: Wed Sep 14 07:06:20 2005 >>New Revision: 280860 >> >>URL: http://svn.apache.org/viewcvs?rev=280860&view=rev >>Log: >>Replace the multiproject:goal by the reactor (workaround for MAVEN-1691). >>Fix all tests in all plugins. >> >>Removed: >> maven/maven-1/plugins/trunk/abbot/src/plugin-test/project.properties >> maven/maven-1/plugins/trunk/clover/src/plugin-test/project.properties >> maven/maven-1/plugins/trunk/cruisecontrol/src/plugin- >>test/project.properties >> maven/maven-1/plugins/trunk/eclipse/src/plugin-test/project.properties >>Modified: >> maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml >> maven/maven-1/plugins/trunk/clover/src/plugin-test/maven.xml >> maven/maven-1/plugins/trunk/cruisecontrol/src/plugin-test/maven.xml >> maven/maven-1/plugins/trunk/dashboard/src/plugin-test/maven.xml >> maven/maven-1/plugins/trunk/dashboard/src/plugin- >>test/project.properties >> maven/maven-1/plugins/trunk/eclipse/src/plugin-test/maven.xml >> maven/maven-1/plugins/trunk/maven.xml >> >>Modified: maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml >>URL: http://svn.apache.org/viewcvs/maven/maven- >>1/plugins/trunk/abbot/src/plugin- >>test/maven.xml?rev=280860&r1=280859&r2=280860&view=diff >>========================================================================== >>==== >>--- maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml (original) >>+++ maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml Wed Sep 14 >>07:06:20 2005 >>@@ -1,6 +1,6 @@ >> <?xml version="1.0"?> >> >>-<project xmlns:j="jelly:core"> >>+<project xmlns:j="jelly:core" xmlns:maven="jelly:maven"> >> >> <goal name="testPlugin"> >> <echo>This plugin must be tested manually (with the testPlugin-manual >>goal) as it requires defining a build.properties containing environment- >>dependent configuration.</echo> >>@@ -13,8 +13,7 @@ >> environment variable must be set. --> >> >> <goal name="testPlugin-manual"> >>- <j:set var="goal" value="dist"/> >>- <attainGoal name="multiproject:goal"/> >>+ <maven:reactor basedir="${basedir}" includes="*/project.xml" >>goals="dist" banner="Test" ignoreFailures="false"/> >> </goal> >> >> > >[snip] > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
