> -----Original Message----- > From: Brett Porter [mailto:[EMAIL PROTECTED] > Sent: vendredi 23 septembre 2005 09:40 > To: Maven Developers List > Subject: Re: svn commit: r291085 - /maven/components/trunk/maven- > plugins/maven-clover- > plugin/src/main/java/org/apache/maven/plugin/clover/CloverReportMojo.java > > Vincent Massol wrote: > > >Could you please explain the rationale for this? > > > > > I was getting annoyed at guessing between [plugin-name], report and > generate. > > Since some plugins have more than one report, I picked the one people > are probably most familiar with. It's the primary purpose the plugin. > Eg. Changelog has "changelog:changelog", "changelog:dev-activity", > "changelog:file-activity". Would you make the first :report and append > -report to the others? append -report to the first? Rename the plugin to > maven-scm-reports (which we've discussed too :)
Well, naming a goal with the plugin's name doesn't help in solving the name issue when you have several reports for example... So you name the first one with the plugin name but what about the second one, third one, etc? :-) > It was also the least number of changes to make. That's a good reason... > >I'm quite strongly against it unless there is a very good reason which I > >don't see ATM (I don't consider the fact that other plugins do it a good > >enough reason - I think they are also wrong ;-)). Maybe my wording was a bit strong here... :-) > I think its right for the reasons above, but we can discuss/change > before the next releases. > > >The reasons I don't like it: > > > >- The name clover for a goal doesn't mean anything. "clover:report" is > much > >better than "clover:clover" for understanding what the goal does. > > > > > It doesn't execute clover on it? What would you rename jar:jar to then? Well the whole clover plugin is about .... guess what?... clover! :-) How many mojos does that JAR plugin has? > >- I don't think the report goal should be more important than another one > in > >the Clover plugin. There are different goals that do different things > >(clover:check, clover:report, etc). > > > > > You don't think that it is what most people expect as the default > behaviour? Yeah I'm not against the fact that it may be the most used goal... I was more against the fact of renaming it. Adding an alias would be fine for me. [snip] -Vincent --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
