[ http://jira.codehaus.org/browse/MNG-1185?page=comments#action_48502 ]
Martin Desruisseaux commented on MNG-1185: ------------------------------------------ Thanks for taking care of this issue :) (actually, I wonder if the priority should have been something higher than "major", since any fix applied is going to be a compatibility break for users). Actually, I just realized that a parameter already exists in the "site:site" goal for exactly this purpose, and the parameter name is <outputDirectory>. This make a lot of sense, since I tend to associate <deployDirectory> to the directory where the HTML pages are going to be deployed on the server (rather then the developer machine). Furthermore, <outputDirectory> is consistent with the "compiler:compile" goal (http://maven.apache.org/maven2/plugins/maven-compiler-plugin/compile-mojo.html), which has an <outputDirectory> parameter for very similar purpose. Since (at the difference of the issue reported here), the "compiler:compile" goal is in a different phase and different Mojo, using the same parameter name does not conflict. - In "compiler:compile", default value for <outputDirectory> is ${project.build.outputDirectory}. - In "site:site", default value for <outputDirectory> is ${project.reporting.outputDirectory}. Concequently (if someone has administrative right on JIRA), I suggest to take the following actions: 1) Rename the title for this issue as "in site:deploy, rename parameter <siteDirectory> as <outputDirectory>". 2) Maybe raise the priority, since fixing this issue involves a compatibility break for users (better to not wait to much in order to limit the dependencies to current name on user side). > Parameter <siteDirectory> in goal "site" conflicts with parameter of the same > name in goal "deploy" > --------------------------------------------------------------------------------------------------- > > Key: MNG-1185 > URL: http://jira.codehaus.org/browse/MNG-1185 > Project: Maven 2 > Type: Bug > Components: maven-site-plugin > Versions: 2.0-beta-4 > Reporter: Martin Desruisseaux > Assignee: Johnny R. Ruiz III > Attachments: MNG-1185-maven-site-plugin.patch > > Original Estimate: 3 hours > Remaining: 3 hours > > In the maven-site-plugin, goals "site" and "deploy" both have a parameter > named <siteDirectory>, but use it for different purpose. > * Goal "site" uses it for locating files like site.xml. The default value is > "${basedir}/src/site". > * Goal "deploy" uses it for locating the HTML pages produces by the goal > "site". The default value is "${project.reporting.outputDirectory}". > Consequently, setting this parameter for one goal has undesirable side effect > on the other goal. It basically prevent "deploy" to work (unless there is > some way in Maven 2 to setup different parameter values for different goals > in the same plugin). > A possible fix is to rename the <siteDirectory> parameter for one of those > goals. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
