-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 is there an issue for this yet?
Brett Porter wrote: | This is a poorly encapsulated class that needs some work. | | base version should always be "-SNAPSHOT", while version should be | "-2005..." | | - Brett | | Donszelmann, Mark wrote: | |> Hi |> |> the following code in DefaultArtifact.java changes the behaviour of |> the getBaseVersion() method. |> |> -- |> public boolean isSnapshot() |> { |> if ( version != null || baseVersion != null ) |> { |> Matcher m = VERSION_FILE_PATTERN.matcher( getBaseVersion() ); |> if ( m.matches() ) |> { |> setBaseVersion( m.group( 1 ) + "-" + SNAPSHOT_VERSION ); |> return true; |> } |> else |> { |> return getBaseVersion().endsWith( SNAPSHOT_VERSION ) |> || getBaseVersion().equals( LATEST_VERSION ); |> } |> } |> else |> { |> return false; |> } |> } |> -- |> |> if I call: |> |> artifact.getBaseVersion() --> 1.9-20051109.225127-1 |> artifact.isSnapshot() --> true |> artifact.getBaseVersion() --> 1.9-SNAPSHOT |> |> is this intentional? Should the code for setting the base version not |> be setBaseVersion ? |> |> Regards |> Mark Donszelmann |> |> --------------------------------------------------------------------- |> To unsubscribe, e-mail: [EMAIL PROTECTED] |> For additional commands, e-mail: [EMAIL PROTECTED] |> | | --------------------------------------------------------------------- | To unsubscribe, e-mail: [EMAIL PROTECTED] | For additional commands, e-mail: [EMAIL PROTECTED] | | | -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (GNU/Linux) iD8DBQFDcr9zK3h2CZwO/4URApznAJ4m2rXIyanvv2H3Atec3SJ8U7WIZwCdHtaC 0nBQwF2AghUfF91K5yI0PAI= =dOPe -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]