[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_52266 ]
John Casey commented on MNG-1113:
---------------------------------
I'm trying to make sense of this whole thing...patch #3
(checkstyle-config-file.patch) would seem to make the most sense to me, if our
goal here is to make the checkstyle plugin work with a project-defined custom
configuration file. I believe it's consistent with our approach in other
plugins, and it would of course be bad form to specify a config file outside of
${basedir}. This will maximize portability, as it's unreasonable to say that
any custom config file be reachable from an HTTP server or other external,
location-independent source (which may present its own portability concerns).
If we have other issues with the checkstyle plugin than custom XML
configuration files, can we please make sure they are filed in separate issues,
against the maven-checkstyle-plugin component? Otherwise, it'll be hard to know
what we're trying to achieve here, or when it's really fixed.
So, my plan: apply checkstyle-config-file.patch and close this issue. Is this
alright with everyone?
> Plugin does not support using custom checkstyle XML config file
> ---------------------------------------------------------------
>
> Key: MNG-1113
> URL: http://jira.codehaus.org/browse/MNG-1113
> Project: Maven 2
> Type: Bug
> Components: maven-checkstyle-plugin
> Versions: 2.0-beta-3
> Reporter: Vincent Massol
> Assignee: Edwin Punzalan
> Attachments: CheckstyleReport.java, MNG-1113-maven-checkstyle-plugin.patch,
> checkstyle-config-file.patch, recommended.txt
>
>
> The plugin source code says:
> /**
> * Specifies the location of the checkstyle properties that will be used
> to check the source.
> *
> * @parameter
> */
> private File propertiesFile;
> But in practice it's only loading *properties* and not the XML. The
> getConfigFile() method is not right and needs to be modified to take into
> account a custom checkstyle config file.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
