[ http://jira.codehaus.org/browse/MNG-1696?page=comments#action_52458 ] 

David Hawkins commented on MNG-1696:
------------------------------------

It was developed against repository version 349429.  I just reverted my src 
directory, updated to the latest (350051) and patched my source with the patch. 
 I tested both include and excludes (single and comma separated) and they work 
properly. 

What is the behavior that you are seeing?

As to your second reply, the suggesting of adding:
If ( warSourceExcludes != null && !"".equals( warSourceExcludes ) )

Is taken care of by StringUtils:
if ( StringUtils.isNotEmpty( warSourceExcludes ) )

And there is no need to add the default FileUtils.getDefaultExcludesAsList 
because they automatically added on line 463 with a call to 
scanner.addDefaultExcludes();

I think you might be working with an old version of the source or something. 

--David


> war includes and excludes don't handle comma separated tokens (patch included)
> ------------------------------------------------------------------------------
>
>          Key: MNG-1696
>          URL: http://jira.codehaus.org/browse/MNG-1696
>      Project: Maven 2
>         Type: Bug
>   Components: maven-war-plugin
>     Reporter: David Hawkins
>  Attachments: MNG-1696-maven-war-plugin.patch
>
>
> The documentation for warSourceIncludes, warSourceExcludes, 
> dependantWarIncludes, and dependantWarExcludes all state something that they 
> support comma delimited tokens but it simply doesn't work when a comma is 
> specified. This patch makes all four parameters properly process comma 
> delimited values.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to