[ http://jira.codehaus.org/browse/MNG-661?page=comments#action_53143 ] 

John Allen commented on MNG-661:
--------------------------------

re the patch,

theres a bug in the SiteStageMojo::getStructure() method under windows.

Windows distribution paths can start with drive prefixes and thus we need to 
sanitize the ':' as its illegal in the newly generated compound path.

Dont have a patch as this is a patch on a patch with no revision to compare 
against but starting at line 157:-

        Repository repository = new Repository( site.getId(), site.getUrl() );
        if ( StringUtils.isEmpty( repository.getBasedir() ) )
        {
            return repository.getHost();
        }

        // might need to sanitize a drive letter under windows (eg. D:\)
        
        String baseDir = repository.getBasedir();
        
        if ( baseDir.charAt(1) == ':' )
        {
                StringBuffer buffer = new StringBuffer(); 
                buffer.append( baseDir.charAt( 0 ) );
                
                if ( baseDir.length() > 3 )
                {
                        buffer.append( baseDir.substring( 2 ) );
                }
                
                baseDir = buffer.toString() ;

            System.out.println( "new baseDir = " + baseDir );
        }
        
        if ( baseDir.startsWith( "/" ) )
        {
            return repository.getHost() + baseDir;
        }





> In parent site, automatically create link to modules sites and vice-versa
> -------------------------------------------------------------------------
>
>          Key: MNG-661
>          URL: http://jira.codehaus.org/browse/MNG-661
>      Project: Maven 2
>         Type: Improvement

>   Components: maven-site-plugin
>     Versions: 2.0-alpha-3
>     Reporter: Yann Le Du
>     Assignee: Vincent Siveton
>     Priority: Minor
>      Fix For: 2.0.2
>  Attachments: MNG-661.diff, MNG-661.diff, SiteMojoPatch.txt, 
> SiteMojoPatch.txt, SiteMojoPatch.txt, site-plugin-multiproject.zip
>
>
> Say we have the following project structure :
> A
> +-- B
>     +-- C
> +-- D
> It would be nice to have the following links in the left menu of the 
> generated sites :
> A :
> Modules : B, D
> B :
> Parent : A
> Modules : C
> C :
> Parent : B
> D :
> Parent : A

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to