[ http://jira.codehaus.org/browse/MASSEMBLY-25?page=comments#action_54758 ] 

Jochen Wiedmann commented on MASSEMBLY-25:
------------------------------------------

Comments on Bretts reply:

- Retaining includeSiteDirectory: The proposed patch does retain this property.
  I have no idea, how to mark properties as deprecated, though,
- Explicit descriptor list: To me, it doesn't matter how multiple descriptors 
may
  are being specified. I do not know how to create nested elements like
  "descriptors", though.
- Retaining descriptor/descriptorId: Same thing than includeSiteDirectory.

Summary: I'd be glad to modify my patch following your guidelines, if you can 
tell me how to solve the above questions.


> Support for multiple assembly descriptors
> -----------------------------------------
>
>          Key: MASSEMBLY-25
>          URL: http://jira.codehaus.org/browse/MASSEMBLY-25
>      Project: Maven 2.x Assembly Plugin
>         Type: Bug

>     Reporter: Jochen Wiedmann
>     Assignee: Brett Porter
>      Fix For: 2.1
>  Attachments: assembly.patch, assembly2.patch
>
>
> The attached patch adds two new features:
> - It allows to specify the "includeSiteDirectory" property in the assembly 
> descriptor.
>   IMO, this is the place, where it should be, because this typically depends 
> on the
>   descriptor. For example, you would want the site in a "bin" distribution, 
> but not in
>   the "src" distribution.
> - It allows to specify multiple descriptors via the properties "dir", 
> "includes", and
>   "excludes". Typically, one would use dir=src/main/assembly, and 
> includes=*.xml.
> I'd personally prefer to support even multiple "dir/includes/excludes" 
> triplets, but I
> do not know, how this is done in a Mojo.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to