Check the project lead: http://jira.codehaus.org/browse/MASSEMBLY It should be you, Brett, right? :)
Cheers, Stéphane On 1/4/06, Brett Porter <[EMAIL PROTECTED]> wrote: > There isn't anything documented on the naming of variables, but would > suggest following the surrounding code. I was referring to things like > "pAssembly", where we usually stick to just "assembly". > > Thanks, > Brett > > Jochen Wiedmann wrote: > > > > Brett, > > > > I was aware of a certain code style, when it comes to indentation, and > > the like. I did my best to follow that code style. However, I am > > completely lost, when it comes to a code style in terms of variable > > names. Any additional hints on that? > > > > Regards, > > > > Jochen > > > > > > ------------------------------------------------------------------------ > > > > Subject: > > [jira] Commented: (MASSEMBLY-25) Support for multiple assembly descriptors > > From: > > "Brett Porter (JIRA)" <[EMAIL PROTECTED]> > > Date: > > Tue, 3 Jan 2006 18:21:13 -0600 (CST) > > To: > > [EMAIL PROTECTED] > > > > To: > > [EMAIL PROTECTED] > > > > > > [ > > http://jira.codehaus.org/browse/MASSEMBLY-25?page=comments#action_54825 ] > > > > Brett Porter commented on MASSEMBLY-25: > > --------------------------------------- > > > > comment on the patch: please follow existing code style. I have to > > reformat, which is easy, but renaming all the variables is a bit tedious. > > > >> Support for multiple assembly descriptors > >> ----------------------------------------- > >> > >> Key: MASSEMBLY-25 > >> URL: http://jira.codehaus.org/browse/MASSEMBLY-25 > >> Project: Maven 2.x Assembly Plugin > >> Type: Bug > > > >> Reporter: Jochen Wiedmann > >> Assignee: Brett Porter > >> Fix For: 2.1 > >> Attachments: assembly.patch, assembly2.patch > >> > >> > >> The attached patch adds two new features: > >> - It allows to specify the "includeSiteDirectory" property in the assembly > >> descriptor. > >> IMO, this is the place, where it should be, because this typically > >> depends on the > >> descriptor. For example, you would want the site in a "bin" > >> distribution, but not in > >> the "src" distribution. > >> - It allows to specify multiple descriptors via the properties "dir", > >> "includes", and > >> "excludes". Typically, one would use dir=src/main/assembly, and > >> includes=*.xml. > >> I'd personally prefer to support even multiple "dir/includes/excludes" > >> triplets, but I > >> do not know, how this is done in a Mojo. > > > > > > ------------------------------------------------------------------------ > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- .::You're welcome ::. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
