[ http://jira.codehaus.org/browse/SCM-134?page=comments#action_56508 ] 

Dennis Lundberg commented on SCM-134:
-------------------------------------

I'm not sure if it necessary, but it should not hurt. The reason I found this 
is that I'm pursuing a bug in the maven-1 plugin. I thought that this 
inconsistency could have something to do with it, but it did not. Since I had 
already written the code I thought I might as well submit it.

You might want to consider the scm url related fixes.

> Set CVSROOT consistently in all commands in cvs-provider
> --------------------------------------------------------
>
>          Key: SCM-134
>          URL: http://jira.codehaus.org/browse/SCM-134
>      Project: Maven SCM
>         Type: Bug

>   Components: maven-scm-provider-cvs
>     Versions: 1.0-beta-3
>     Reporter: Dennis Lundberg
>  Attachments: SCM-134.patch
>
>
> Most of the commands in the cvs provider use the command line argument "-d 
> CVSROOT", but not all of them.
> The attached patch adds "-d CVSROOT" to these commands:
> * CvsDiffCommand
> * CvsStatusCommand
> * CvsUpdateCommand
> This change also made it necessary to alter the CvsUpdateCommandTest so that 
> it works on Windows.
> That test now uses CvsScmTestUtils.getScmUrl() to get an scmUrl.
> CvsScmTestUtils.getScmUrl() has been corrected to use the vertical bar "|" as 
> the delimiter in all places of the scm url.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to