i think it's something that while you are working on it is easy to
fix, but if you receive the notification after some time it's more
annoying, opening again the file, fix it, submit again, see if it
fails...
I think it's like test coverage, if you don't have enough you can't
leave the sandbox, and once you leave it you are required to keep the
quality of the work.
I agree that there may be exceptions when it needs to be skipped for a
good reason, but I see that as exceptions more than the rule.
It's like the repository, as there are no policies enforced
automatically, you can deploy and then chase the people, which slows
down the work of other people.
And right now i just added duplication report, thinking that it's a no
no to include duplicated lines. In the future I'd like to add
checkstyle and PMD.
my 2 cents
---------- Forwarded message ----------
From: Brett Porter <[EMAIL PROTECTED]>
Date: Jun 23, 2006 3:48 AM
Subject: Re: svn commit: r416184 - /maven/pom/maven/pom.xml
To: Maven Developers List <[email protected]>
If it slows down the build, people will turn it off forcably/complain,
etc too.
We can enable the profile for CI and deployment, which might make it
better. WDYT?
However, I don't know if this should be a "deployment failure" type
issue - I'd be happy with daily nags on it.
- Brett
On 23/06/2006 11:42 AM, Carlos Sanchez wrote:
My (limited) experience tells me that if you don't enforce it you
don't get it done
If it's in a profile I can deploy it and then continuum will fail and
somebody will have to chase me and tell me and then I'd have to fix
it, which means that the turnaround is pretty big.
I just added now the duplicate lines thing but I'd like to add also
checkstyle and pmd to enforce some common rules.
On 6/23/06, Brett Porter <[EMAIL PROTECTED]> wrote:
So, you'll fix all duplications when you change the parent?
I still believe this should be in a profile used by CI. The standard
build doesn't need to worry about this.
- Brett
On 23/06/2006 1:18 AM, Carlos Sanchez wrote:
> That's the point, don't accept files with duplications. Better enforce
> it proactively.
>
> On 6/22/06, Brett Porter <[EMAIL PROTECTED]> wrote:
>> On 22/06/2006 10:27 AM, [EMAIL PROTECTED] wrote:
>> > Author: carlos
>> > Date: Wed Jun 21 17:27:49 2006
>> > New Revision: 416184
>> >
>> > URL: http://svn.apache.org/viewvc?rev=416184&view=rev
>> > Log:
>> > Added checkstyle configuration and pmd check for duplications
>>
>> Won't that fail the build?
>>
>> Shouldn't the checks be in a profile?
>>
>> - Brett
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
>
--
Brett Porter <[EMAIL PROTECTED]>
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Brett Porter <[EMAIL PROTECTED]>
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
