yah, we can change the name, I was just making it consistent with the repository manager one I had already set up.

Continuum still forks all the builds, so I'm not sure why using the system property would be harder, it's just an additional property you can use instead of -P (which I have had problems using to set multiple profiles before which makes the property useful).

- Brett

On 27/06/2006 11:17 PM, Trygve Laugstøl wrote:
[EMAIL PROTECTED] wrote:
Author: brett
Date: Mon Jun 26 21:17:46 2006
New Revision: 417335

URL: http://svn.apache.org/viewvc?rev=417335&view=rev
Log:
make activation more consistent

Modified:
    maven/plugins/trunk/pom.xml

Modified: maven/plugins/trunk/pom.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/pom.xml?rev=417335&r1=417334&r2=417335&view=diff ==============================================================================
--- maven/plugins/trunk/pom.xml (original)
+++ maven/plugins/trunk/pom.xml Mon Jun 26 21:17:46 2006
@@ -80,7 +80,13 @@
   </reporting>
   <profiles>
     <profile>
-      <id>ci</id>
+      <id>ciProfile</id>
+      <activation>
+        <property>
+          <name>enableCiProfile</name>
+          <value>true</value>
+        </property>
+      </activation>

I don't get this. Why not just call the profile "ci" or "ciProfile" and just activate it with -Pci? What's the point in using the system property to enable it?

Continuum should probably natively support the concept of profiles and enable them per build configuration, which makes system property-based profiles a bit harder.

--
Trygve

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



--
Brett Porter <[EMAIL PROTECTED]>
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to