Good day, I see. Thanks again...and don't worry, I'll play it safe next time ^_^
- Franz On 7/22/06, Brett Porter <[EMAIL PROTECTED]> wrote:
This wasn't your fault - you were actually doing the "right thing" considering the current state of SVN, however this is not backwards compatible and so changes need to be considered in that context too. What happened is that in r399801 maven-archetype-bundles/pom.xml changes the group ID of all the archetypes. None have been released from this POM yet. I'll correct SVN now, so no need to review the patch - however I will ask that before making changes (and same goes for reviewers of patches), that the consequences be considered. If you are unsure - just ask - someone will know here. Thanks for the patch! Cheers, Brett On 22/07/2006 5:55 AM, FA Valencia See wrote: > Good day to you, > > I see. Thanks for the correction and sorry about that. Everything > related to > it was all about "archetype" that I thought it was just a typo-error. > > Anyway, I'd revise the patch to accomadate your comments. However, I'd just > like to clarify your comment regarding the parent pom. are you referring to > the artifact-id of the parent pom (meaning convert "maven-archetype-parent" > to "maven-archetypes-parent")? > > Thanks > > - Franz > > On 7/21/06, Brett Porter <[EMAIL PROTECTED]> wrote: >> >> -1 on the first change. Please revert that part of the patch. >> >> All of the released archetypes so far are under "archetypes", not >> "archetype". >> >> http://repo1.maven.org/maven2/org/apache/maven/archetypes/ >> >> It seems that the parent pom for the archetypes was also changed to >> "archetype" at some point in the past. It should be changed back to >> maintain compatibility instead. >> >> - Brett >> >> On 21/07/2006 7:35 PM, [EMAIL PROTECTED] wrote: >> > Author: aramirez >> > Date: Fri Jul 21 02:35:32 2006 >> > New Revision: 424243 >> > >> > URL: http://svn.apache.org/viewvc?rev=424243&view=rev >> > Log: >> > PR: ARCHETYPE-36 >> > Submitted By: Franz Allan See >> > >> > -changed the default-value of the archetypeGroupId from " >> org.apache.maven.archetypes" to "org.apache.maven.archetype" >> > >> > -removed some lines in the <resources> tag >> > >> > Modified: >> > >> maven/archetype/trunk/maven-archetype-bundles/maven-archetype-j2ee-simple/src/main/resources/META-INF/archetype.xml >> >> > >> maven/archetype/trunk/maven-archetype/maven-archetype-plugin/src/main/java/org/apache/maven/plugin/archetype/MavenArchetypeMojo.java >> >> > >> > Modified: >> maven/archetype/trunk/maven-archetype-bundles/maven-archetype-j2ee-simple/src/main/resources/META-INF/archetype.xml >> >> > URL: >> http://svn.apache.org/viewvc/maven/archetype/trunk/maven-archetype-bundles/maven-archetype-j2ee-simple/src/main/resources/META-INF/archetype.xml?rev=424243&r1=424242&r2=424243&view=diff >> >> > >> ============================================================================== >> >> > --- >> maven/archetype/trunk/maven-archetype-bundles/maven-archetype-j2ee-simple/src/main/resources/META-INF/archetype.xml >> >> (original) >> > +++ >> maven/archetype/trunk/maven-archetype-bundles/maven-archetype-j2ee-simple/src/main/resources/META-INF/archetype.xml >> >> Fri Jul 21 02:35:32 2006 >> > @@ -12,8 +12,5 @@ >> > <resource>servlets/servlet/pom.xml</resource> >> > <resource>servlets/servlet/src/main/webapp/index.jsp</resource> >> >> > >> <resource>servlets/servlet/src/main/webapp/WEB-INF/web.xml</resource> >> > - <resource>site/pom.xml</resource> >> > - <resource>site/src/site/site.xml</resource> >> > - <resource>site/src/site/apt/site.apt</resource> >> > </resources> >> > </archetype> >> > >> > Modified: >> maven/archetype/trunk/maven-archetype/maven-archetype-plugin/src/main/java/org/apache/maven/plugin/archetype/MavenArchetypeMojo.java >> >> > URL: >> http://svn.apache.org/viewvc/maven/archetype/trunk/maven-archetype/maven-archetype-plugin/src/main/java/org/apache/maven/plugin/archetype/MavenArchetypeMojo.java?rev=424243&r1=424242&r2=424243&view=diff >> >> > >> ============================================================================== >> >> > --- >> maven/archetype/trunk/maven-archetype/maven-archetype-plugin/src/main/java/org/apache/maven/plugin/archetype/MavenArchetypeMojo.java >> >> (original) >> > +++ >> maven/archetype/trunk/maven-archetype/maven-archetype-plugin/src/main/java/org/apache/maven/plugin/archetype/MavenArchetypeMojo.java >> >> Fri Jul 21 02:35:32 2006 >> > @@ -68,7 +68,7 @@ >> > private ArtifactRepository localRepository; >> > >> > /** >> > - * @parameter expression="${archetypeGroupId}" default-value=" >> org.apache.maven.archetypes" >> > + * @parameter expression="${archetypeGroupId}" default-value=" >> org.apache.maven.archetype" >> > * @required >> > */ >> > private String archetypeGroupId; >> > >> > >> >> >> -- >> Apache Maven - http://maven.apache.org/ >> Better Builds with Maven - http://library.mergere.com/ >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > -- Apache Maven - http://maven.apache.org/ Better Builds with Maven - http://library.mergere.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
