Ok, I should have read lists in the other order :)
I think we should put the site plugin changes on the branch for now.
We can't move the reporting api to a shared space as the maven core
requires it. I think it makes sense to keep the impl and api together
and on the same release timelines.
I didn't check, but if sink-api changes were made this is the same deal.
I know we need to better decouple some of the implementations and apis
in the maven-core. Ideally, only the things the maven-core needs from
the other parts should be in the general API and that would be locked
down. The plugins should have as few callbacks into that as possible. So
I think we need to do a bit of redesigning of that, especially in this
case as the Maven core really only needs the report interface, not even
the methods I think.
Add it to the 2.1 list ;)
- Brett
On 11/08/2006 3:32 AM, Kenney Westerhof wrote:
Hi,
I've just committed some changes WRT MNG-2410 which I've been sitting
on for weeks/months now.
I've just tested them out extensively, and they work fine.
I've had to change the maven-reporting-api and add a new 'generate' method.
I've done that in a new interface 'MavenMultiPageReport', so we can
retain backwards
compatibility.
There's just one problem: I had to update the dep in the
maven-site-plugin on
maven-reporting to 2.1-SNAPSHOT. This will block releases of the
maven-site-plugin.
This feature is planned for 2.1, but the reporting stuff is spread over
maven components,
doxia, and the site plugin. The site plugin has a different release
cycle, so it's impossible
to implement it without having the plugin depend on 2.1 (unless it's
backported to the 2.0.x branch
which we don't want since it's a new feature.)
Ideally I'd like to remove the reporting api/impl from the components
and put it in some shared
plugin space. Since reports are just mojo's we don't really need them in
core. The entire reporting
stuff is only used from the maven-site-plugin, so they're actually
plugins for the site plugin
(functionally seen).
I guess we're now seeing that plugins that depend on core api's can't
really have a totally separate
release cycle. Maybe we need 2 level versions for plugins (i.e. a branch
for plugins that operate on 2.0.x
and trunk that'll operate on 2.1.)
So, I've been waiting quite a while with this with little or no
feedback, and I just went along
and committed this. I'm sure there'll be a reaction now :-)
I really don't know how to solve the problem above, any feedback is
greatly appreciated!
-- Kenney
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
