> 2) I'm getting a test failure on my machine.   I'll look into it a bit
> more this afternoon if I get some time.   Stack trace:

I tracked this down.... 

It's a test that relies on a particular behavior that doesn't seem to be 
valid 100% of the time.  

On line 89 of:
src/main/java/org/apache/maven/plugin/pmd/CpdReport.java
you see:
List files = getFilesToProcess( "**/*.java" );

The test that is failing on my machine seems to expect that the returned 
list of files is sorted, or at least in a particular order.   However, 
there is nothing in getFilesToProcess that guarantees that and on my 
machine, the resulting list is definitely not sorted.   Maybe my 
filesystem orders things differently or something.   I don't really know.

If I add a "Collections.sort(files);" immediately afterword, the test does 
pass.   However, I'm not sure if that's what we want or if the test 
should be updated to allow for sorted and non-sorted behavior.

Personally, I prefer the sort.   I hate reports and such that would be 
different depending on who's machine was used to run it.   However, there 
is a performance impact on that.   Thus, I'm asking others for what they 
think.

-- 
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727    C: 508-380-7194   F:781-902-8001
[EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to