Arnaud HERITIER wrote:
On 1/9/07, Dennis Lundberg <[EMAIL PROTECTED]> wrote:
Brett Porter wrote:
> ok, commented on them all.
Thanks for the feedback Brett. I've closed three of them. Here's an
example site which shows the new externalLink image in action:
http://people.apache.org/~dennisl/doxia/
Hi Denis,
Just some notes:
1) In m1 I removed the external icon from links to not lost too many pixels
for example : http://maven.apache.org/maven-1.x/plugins/pmd/
I just add it in the body of the page (and perhaps in the menu but I'm not
sure)
It's a matter of taste I guess. I have yet to see a site with so many
links that they can't fit. If you really have that many links I'd start
thinking about creating a "related links" page anyway.
2) Why do you have external links for maven projects ? Is it because your
are deploying on people.apache.org ? In m1 I used the url of the project to
find if the domain was the same or not.
I think so. I believe that M2 check more that just the domain when
deciding whether the link is external or not. I think the links will not
be external when the site is published to its real location.
my 2 m1 comments ;-)
Arnaud
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
