Jason van Zyl <[EMAIL PROTECTED]> writes:
But then plugins needing to build ids need a dependency on the xhtml
module. Is that better? And link/anchor generation is needed for
e.g. pdf, too.
Providing this functionality would IMHO be the job of the core of a
system, not one of the components.
Best regards
Henning
>On 22 Mar 07, at 7:28 PM 22 Mar 07, Henning P. Schmiedehausen wrote:
>> Jason van Zyl <[EMAIL PROTECTED]> writes:
>>
>>> On 22 Mar 07, at 11:56 AM 22 Mar 07, Emmanuel Venisse wrote:
>>
>>>> I think we'll need to modify more report plugins with the same patch
>>>>
>>
>>> No, I should just put the HtmlTools back and deprecate it.
>>
>>> I didn't know people were pulling out core utilities, but not
>>> surprising. I'll restore the original location.
>>
>> And how are plugins supposed to generate the same link information as
>> the Doxia core? That is the reason why that patch went in there in the
>> first place.
>>
>> There was a change in the way Doxia created attributes on the pages
>> and Plugins which reference these attributes (e.g. html anchors)
>> suddently broke.
>>
>> At least in my understanding, you provide a class that offers this
>> functionality in a central place and let both pieces (Doxia and the
>> plugins) reference it so that the next change will not break this
>> again.
>>
>> Just deprecating the class and saying "do no longer use it" is IMHO
>> not the right way to go.
>>
>It needs to go into the module where it belongs. It should not be
>used from its current location as it doesn't belong there.
>it belongs in the xhtml module.
>> Best regards
>> Henning
>>
>>
>>
>>
>>
>>> Jason.
>>
>>>> Emmanuel
>>>>
>>>> Emmanuel Venisse a écrit :
>>>>> Fixed.
>>>>> Wendy Smoak a écrit :
>>>>>> On 3/22/07, Emmanuel Venisse <[EMAIL PROTECTED]> wrote:
>>>>>>
>>>>>>> All is fixed, but I can't deploy doxia because files are in read
>>>>>>> mode for group.
>>>>>>> Jason, can you fix it?
>>>>>>
>>>>>> Thanks. Your Doxia change fixed 'mvn site' but now I'm seeing a
>>>>>> problem in the Changes plugin:
>>>>>>
>>>>>> ERROR] BUILD FAILURE
>>>>>> [INFO]
>>>>>> ------------------------------------------------------------------
>>>>>> --
>>>>>> ----
>>>>>> [INFO] Compilation failure
>>>>>>
>>>>>> /home/continuum/working-directory/8/src/main/java/org/apache/
>>>>>> maven/plugin/changes/ChangesReportGenerator.java:[22,37]
>>>>>> package org.apache.maven.doxia.module does not exist
>>>>>>
>>>>>> /home/continuum/working-directory/8/src/main/java/org/apache/
>>>>>> maven/plugin/changes/ChangesReportGenerator.java:[188,60]
>>>>>> cannot find symbol
>>>>>> symbol : variable HtmlTools
>>>>>> location: class
>>>>>> org.apache.maven.plugin.changes.ChangesReportGenerator
>>>>>>
>>>>> -------------------------------------------------------------------
>>>>> --
>>>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>>
>>>>
>>>> --------------------------------------------------------------------
>>>> -
>>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>>
>>>>
>>
>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>> --
>> Henning P. Schmiedehausen -- [EMAIL PROTECTED] | J2EE,
>> Linux, |gls
>> 91054 Buckenhof, Germany -- +49 9131 506540 | Apache
>> person |eau
>> Open Source Consulting, Development, Design | Velocity - Turbine
>> guy |rwc
>>
>> |m k
>> INTERMETA - Gesellschaft fuer Mehrwertdienste mbH - RG Fuerth, HRB
>> 7350 |a s
>> Sitz der Gesellschaft: Buckenhof. Geschaeftsfuehrer: Henning
>> Schmiedehausen |n
>>
>> "Save the cheerleader. Save the world."
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
--
Henning P. Schmiedehausen -- [EMAIL PROTECTED] | J2EE, Linux,
|gls
91054 Buckenhof, Germany -- +49 9131 506540 | Apache person |eau
Open Source Consulting, Development, Design | Velocity - Turbine guy |rwc
|m k
INTERMETA - Gesellschaft fuer Mehrwertdienste mbH - RG Fuerth, HRB 7350 |a s
Sitz der Gesellschaft: Buckenhof. Geschaeftsfuehrer: Henning Schmiedehausen |n
"Save the cheerleader. Save the world."
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
