On 1 Jun 07, at 8:06 PM 1 Jun 07, [EMAIL PROTECTED] wrote:

Author: carlos
Date: Fri Jun  1 17:06:11 2007
New Revision: 543671

URL: http://svn.apache.org/viewvc?view=rev&rev=543671
Log:
[MNG-2943] Avoid using package names used in other artifacts: add some comments


-1

Roll all of those back. I'm not if you haven't noticed but we're trying to process patches across both the trunk and the branch and you:

1) Making an assumption about how the embedder is going to be deployed yourself while I have historically always had clients consume a single JAR/Bundle 2) Making it difficult for us to patch across the branch and trunk for no good reason given the embedder has always been proffered up as a single JAR 3) Should ask on things you historically have never had anything to do with

The embedder will continue to be a single bundle/jar as it has always been until you convince me (the one who has always done the work and released the embedder to anyone using it from its inception) otherwise. It might be a great idea for reasons I can't fathom but for the love of god stop diddling everything that you historically did not start or have had nothing to do with.

Modified:
    maven/components/trunk/maven-core/pom.xml
maven/components/trunk/maven-core/src/main/java/org/apache/ maven/core/monitor/event/DefaultEventMonitor.java maven/components/trunk/maven-core/src/main/java/org/apache/ maven/core/monitor/logging/DefaultLog.java
    maven/components/trunk/maven-settings/pom.xml
maven/components/trunk/maven-settings/src/main/java/org/apache/ maven/settings/SettingsConfigurationException.java

Modified: maven/components/trunk/maven-core/pom.xml
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/ pom.xml?view=diff&rev=543671&r1=543670&r2=543671 ====================================================================== ========
--- maven/components/trunk/maven-core/pom.xml (original)
+++ maven/components/trunk/maven-core/pom.xml Fri Jun  1 17:06:11 2007
@@ -157,6 +157,7 @@
         <artifactId>maven-bundle-plugin</artifactId>
         <configuration>
           <instructions>
+            <!-- do not export deprecated packages -->
<Export-Package>!org.apache.maven.monitor.*,*</Export- Package>
           </instructions>
         </configuration>

Modified: maven/components/trunk/maven-core/src/main/java/org/ apache/maven/core/monitor/event/DefaultEventMonitor.java URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/ src/main/java/org/apache/maven/core/monitor/event/ DefaultEventMonitor.java?view=diff&rev=543671&r1=543670&r2=543671 ====================================================================== ======== --- maven/components/trunk/maven-core/src/main/java/org/apache/ maven/core/monitor/event/DefaultEventMonitor.java (original) +++ maven/components/trunk/maven-core/src/main/java/org/apache/ maven/core/monitor/event/DefaultEventMonitor.java Fri Jun 1 17:06:11 2007
@@ -25,6 +25,7 @@

 /**
  * @author jdcasey
+ * @since 2.1
  */
 public class DefaultEventMonitor
     extends AbstractSelectiveEventMonitor

Modified: maven/components/trunk/maven-core/src/main/java/org/ apache/maven/core/monitor/logging/DefaultLog.java URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/ src/main/java/org/apache/maven/core/monitor/logging/DefaultLog.java? view=diff&rev=543671&r1=543670&r2=543671 ====================================================================== ======== --- maven/components/trunk/maven-core/src/main/java/org/apache/ maven/core/monitor/logging/DefaultLog.java (original) +++ maven/components/trunk/maven-core/src/main/java/org/apache/ maven/core/monitor/logging/DefaultLog.java Fri Jun 1 17:06:11 2007
@@ -24,6 +24,7 @@

 /**
  * @author jdcasey
+ * @since 2.1
  */
 public class DefaultLog
     implements Log

Modified: maven/components/trunk/maven-settings/pom.xml
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven- settings/pom.xml?view=diff&rev=543671&r1=543670&r2=543671 ====================================================================== ========
--- maven/components/trunk/maven-settings/pom.xml (original)
+++ maven/components/trunk/maven-settings/pom.xml Fri Jun 1 17:06:11 2007
@@ -52,6 +52,7 @@
         <artifactId>maven-bundle-plugin</artifactId>
         <configuration>
           <instructions>
+            <!-- do not export deprecated packages -->
             <Export-Package>!org.apache.maven,*</Export-Package>
           </instructions>
         </configuration>

Modified: maven/components/trunk/maven-settings/src/main/java/org/ apache/maven/settings/SettingsConfigurationException.java URL: http://svn.apache.org/viewvc/maven/components/trunk/maven- settings/src/main/java/org/apache/maven/settings/ SettingsConfigurationException.java? view=diff&rev=543671&r1=543670&r2=543671 ====================================================================== ======== --- maven/components/trunk/maven-settings/src/main/java/org/apache/ maven/settings/SettingsConfigurationException.java (original) +++ maven/components/trunk/maven-settings/src/main/java/org/apache/ maven/settings/SettingsConfigurationException.java Fri Jun 1 17:06:11 2007
@@ -24,6 +24,7 @@
  *
  * @author <a href="mailto:[EMAIL PROTECTED]">Brett Porter</a>
  * @version $Id$
+ * @since 2.1
  */
 public class SettingsConfigurationException
     extends Exception




Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder and PMC Chair, Apache Maven
jason at sonatype dot com
----------------------------------------------------------




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to