Mark Hobson wrote:
Hi Brett,
On 06/06/07, Mark Hobson <[EMAIL PROTECTED]> wrote:
On 06/06/07, Brett Porter <[EMAIL PROTECTED]> wrote:
> My recollection would be that some artifacts are filtered out but
> their transitive dependencies still needed to be taken into
> consideration for version calculations, so this could be the reason
> for this.
If an artifact is filtered out then why would it's transitive
dependencies impact upon the resolved artifacts? The filtering
performed by DefaultArtifactCollector.filterTrail appears to snip the
branch at any filtered artifact.
Any insight into this? I feel the artifacts should be filtered during
DefaultArtifactCollector.recurse.
AFAIK filtering is only used to filter out core artifacts (so that plugins
don't get ClassCastexceptions etc), but I'm not entirely
sure. If that's the case, then indeed I don't see the need to apply filtering
after the resolution, unless there are plugins that transitively depend on
artifacts
through core artifacts that aren't shaded.
If filtering is used for other purposes than to filter core artifacts then maybe
transitive resolution needs to take place before filtering. I can think of one such
example, being the <excludes> tag (or <exclusions>; I always mix them up) in
dependencies.
If they mean "don't include this artifact anywhere in the transitive dependency
trails",
then filtering needs to take place after resolution.
If they mean "don't include this artifact AND it's dependencies anywhere in the
transitive
dependency trails", then filtering can occur before resolution.
btw, which one is it? I need to doc that in the wiki [1].
Cheers,
Kenney
[1]
http://docs.codehaus.org/display/MAVEN/Maven+2.1+Artifact+Resolution+Specification
Cheers,
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
