On 18 Jun 07, at 10:02 AM 18 Jun 07, Mark Hobson wrote:
Hi there,
I'm working on adding omitted nodes support to dependency-tree and
have come across a limitation within DefaultArtifactCollector. The
problem is when one node is omitted for conflicting with a nearer node
and they have identical versions, i.e. they are duplicate nodes.
You can see in DefaultArtifactCollector.fireEvent for OMIT_FOR_NEARER,
the event is only fired to listeners if the versions differ. Hence
the event is never fired for duplicate nodes, which makes it
impossible to accurately reflect what Maven is doing internally in the
dependency tree. I'd like to remove this restriction to allow
interested listeners to easily track duplicates.
Has anyone got objections to me committing this change to 2.0.x and
2.1?
As long as you run all the ITs and make sure they work before
committing. Running the unit tests is not enough unfortunately.
And I'm still trying to get all the "getting prepared for 2.1" before
I start fleshing out any specs. But the artifact resolution in 2.0.x
is fundamentally wrong in not making a graph of the metadata before
the artifacts are materialized so don't be overly surprised if much
of the structure there gets wiped out in 2.1.
Cheers,
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder and PMC Chair, Apache Maven
jason at sonatype dot com
----------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
