Not that it's entirely relevant, but making the assumption this is archiva motivated is not completely out of the blue. The unit test mentions archiva, the jira mentions archiva, the only site docs I noticed being updated showed how this was used with archiva, the developer that wrote committed and resolved has only 3 commits on core and all the rest are on archiva. So I think it might be a valid assumption...
-----Original Message----- From: Joakim Erdfelt [mailto:[EMAIL PROTECTED] Sent: Sunday, March 16, 2008 12:36 AM To: Maven Developers List Subject: Re: svn commit: r630789 - in /maven/artifact/trunk/src: main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java Jason, Saying that this commit is Archiva-motivated is an incorrect rush to judgment and is insulting. Unprovoked and inaccurate attacks against members of the committer pool are also unhealthy to the community at large. Brian's concerns about this change are valid as is, and need to be addressed. http://jira.codehaus.org/browse/MNG-3407 is the tracking point for this feature now. For the record, I also think this is a wonky solution to a questionable problem. Depending on outcome of the discussion on this list, wiki, and jira, some consensus within the group will be made. This is the professional approach to solving this issue. - Joakim Jason van Zyl wrote: > I also thought this was a little sketchy and is why I don't like the > cross project commit privs because people think it's just ok to do > this kind of thing. > > Due to a limitation in Archiva not being able to deal with a single > URL (which the other repositories managers don't have a problem with) > a hack in Maven itself was done by an Archiva developer. No discussion > either. The proximity and artifactory developers don't have this > luxury and is a mild abuse of the system we have in place here IMO. > > On 15-Mar-08, at 8:29 AM, Brian E. Fox wrote: > >> I'm -1 on this commit for several reasons: >> >> First and foremost, there was no proposal on the wiki or any discussion >> on the dev list that I can see for this. >> >> Second, the use case is not very clear and implementation questionable. >> >> >> >> If this functionality is needed for some reason, it should be brought up >> and discussed in a proposal and on the dev list. We don't just write >> issues, fix them, commit and close the issue with no discussion. Also it >> seems like this change is tailored to support only one repository >> manager which is concerning to me. >> >> >> >> >> >> >> >> _________________________- >> >> >> >> Author: nicolas >> Date: Mon Feb 25 02:18:23 2008 >> New Revision: 630789 >> >> URL: http://svn.apache.org/viewvc?rev=630789&view=rev >> Log: >> MNG-3407 : improve mirrorOf to support pattern based repository URL >> >> Modified: >> >> maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/Def >> aultWagonManager.java >> >> maven/artifact/trunk/src/test/java/org/apache/maven/artifact/manager/Def >> aultWagonManagerTest.java >> >> Modified: >> maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/Def >> aultWagonManager.java >> URL: >> http://svn.apache.org/viewvc/maven/artifact/trunk/src/main/java/org/apac >> he/maven/artifact/manager/DefaultWagonManager.java?rev=630789&r1=630788& >> r2=630789&view=diff >> ======================================================================== >> ====== >> --- >> maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/Def >> aultWagonManager.java (original) >> +++ >> maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/Def >> aultWagonManager.java Mon Feb 25 02:18:23 2008 >> @@ -52,6 +52,7 @@ >> import org.codehaus.plexus.logging.AbstractLogEnabled; >> import >> org.codehaus.plexus.personality.plexus.lifecycle.phase.Contextualizable; >> >> import org.codehaus.plexus.util.FileUtils; >> +import org.codehaus.plexus.util.StringUtils; >> import org.codehaus.plexus.util.xml.Xpp3Dom; >> >> import java.io.File; >> @@ -62,6 +63,7 @@ >> import java.util.Iterator; >> import java.util.List; >> import java.util.Map; >> +import java.text.MessageFormat; >> >> /** @plexus.component */ >> public class DefaultWagonManager >> @@ -754,6 +756,17 @@ >> if ( repository == null ) >> { >> repository = (ArtifactRepository) mirrors.get( WILDCARD ); >> + if ( repository != null ) >> + { >> + String url = repository.getUrl(); >> + if ( url.indexOf( "${mirrorOf}" ) >= 0 ) >> + { >> + url = StringUtils.replace( url, "${mirrorOf}", "{0}" ); >> + url = MessageFormat.format( url, new Object[] { mirrorOf } ); >> + repository = new DefaultArtifactRepository( mirrorOf, url, null ); >> + mirrors.put( mirrorOf, repository ); >> + } >> + } >> } >> >> return repository; >> >> Modified: >> maven/artifact/trunk/src/test/java/org/apache/maven/artifact/manager/Def >> aultWagonManagerTest.java >> URL: >> http://svn.apache.org/viewvc/maven/artifact/trunk/src/test/java/org/apac >> he/maven/artifact/manager/DefaultWagonManagerTest.java?rev=630789&r1=630 >> 788&r2=630789&view=diff >> ======================================================================== >> ====== >> --- >> maven/artifact/trunk/src/test/java/org/apache/maven/artifact/manager/Def >> aultWagonManagerTest.java (original) >> +++ >> maven/artifact/trunk/src/test/java/org/apache/maven/artifact/manager/Def >> aultWagonManagerTest.java Mon Feb 25 02:18:23 2008 >> @@ -56,6 +56,15 @@ >> wagonManager = (WagonManager) lookup( WagonManager.ROLE ); >> } >> >> + public void testMappedMirror() >> + throws Exception >> + { >> + DefaultWagonManager manager = (DefaultWagonManager) wagonManager; >> + manager.addMirror( "wildcar", "*", >> "http://archiva/repository/${mirrorOf}"; ); >> + assertEquals( "http://archiva/repository/central";, manager.getMirror( >> "central" ).getUrl() ); >> + assertEquals( "http://archiva/repository/apache.snapshots";, >> manager.getMirror( "apache.snapshots" ).getUrl() ); >> + } >> + >> public void testDefaultWagonManager() >> throws Exception >> { >> >> >> > > Thanks, > > Jason > > ---------------------------------------------------------- > Jason van Zyl > Founder, Apache Maven > jason at sonatype dot com > ---------------------------------------------------------- > > Simplex sigillum veri. (Simplicity is the seal of truth.) > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
