It's on my todo list. I began to prepare a big refactoring/rewrite of this plugin. it will be a 3.0. I'll give more details about what I have in mind in some weeks cheers
arnaud On Fri, Mar 28, 2008 at 6:03 PM, nicolas de loof <[EMAIL PROTECTED]> wrote: > +1 > > please cleanup the plugin that is allready not so simple to maintain ;-p > > > 2008/3/28, Richard van Nieuwenhoven <[EMAIL PROTECTED]>: > > > > > > Hi, > > > > just created the JIRA http://jira.codehaus.org/browse/MECLIPSE-415 and > > attached the patch. This problem seems to be connected to the wrongly > > used executedProject parameter and maven 2.0.9. > > > > The stage thing is that "testProject11" fails when i remove the usage of > > the executedProject. > > > > Also i am in favour to delete the code in the validate method of the > > EclipsePlugin that allows to use an other directory for the settings as > > the base directory. This code can only work for very very simple > > projects, so we should just delete it. And make the eclipseProjectDir = > > eclipse.projectDir readonly and set it to ${basedir} > > > > Ritchie > > > > Arnaud HERITIER wrote: > > > Ok. Thx a lot. I'll fix it with the executedProject the next week. > > > > > > Arnaud > > > > > > On Fri, Mar 28, 2008 at 12:16 PM, Richard van Nieuwenhoven <[EMAIL > PROTECTED]> > > wrote: > > >> hmmm, that seems to be a relict of the old usage of the workspace > > >> variable usage (that Arnaud removed). Later today i will create an > > jira > > >> issue and a patch. (this should not be hard to find). > > >> > > >> Ritchie > > >> > > >> > > >> > > >> nicolas de loof wrote: > > >> > Also had this issue since 2.5-SNAPSHOTs, but never took the time to > > report > > >> > in Jira :-/ > > >> > > > >> > Setting eclipse.projectDir=${basedir} in the POM eclipse-plugin > > >> > configuration solves this, but this is only a workaround. > > >> > > > >> > Nicolas. > > >> > > > >> > 2008/3/28, Arnaud HERITIER <[EMAIL PROTECTED]>: > > >> >> Hi all, > > >> >> > > >> >> I just discovered a bug, or an hidden feature in 2.5 :-) > > >> >> Richard, I think it is related to MECLIPSE-344. > > >> >> > > >> >> I store my projects in a directory which isn't my eclipse > > workspace. > > >> >> If I define the workspace attribute to be able to read its > > settings, > > >> >> when I call eclipse:eclipse, my projects settings are written in > > the > > >> >> workspace and not in each project's directory. > > >> >> Is it what you expected ? > > >> >> > > >> >> Arnaud > > >> >> > > >> >> N.B. : I will not be able to publish a new version before my > > departure > > >> >> this evening, thus I'll prepare a 1.5.2 just after this one if we > > >> >> decide that we have to fix the plugin (what I'm thinking) > > >> >> > > >> >> > > >> >> > > >> >> On Fri, Mar 28, 2008 at 10:09 AM, nicolas de loof < > > [EMAIL PROTECTED]> > > >> >> wrote: > > >> >>> I've got an issue with eclipse plugin 2.5 & 2.5.1 combined with > > latest > > >> >> maven > > >> >>> 2.0.9 RC4 : > > >> >>> > > >> >>> I've set a custom profile in my corporate POM to setup eclipse. > > It runs > > >> >> the > > >> >>> validate phase and attach eclipse:eclipse plugin goal to this > > phase. > > >> >> Using > > >> >>> this, a fresh SVN checkout can configure eclipse by running "mvn > > >> >> -Psetup" > > >> >>> <profile> > > >> >>> <id>setup</id> > > >> >>> <build> > > >> >>> <defaultGoal>validate</defaultGoal> > > >> >>> <plugins> > > >> >>> <plugin> > > >> >>> <artifactId>maven-eclipse-plugin</artifactId> > > >> >>> <executions> > > >> >>> <execution> > > >> >>> <id>setup</id> > > >> >>> <goals> > > >> >>> <goal>eclipse</goal> > > >> >>> </goals> > > >> >>> <phase>validate</phase> > > >> >>> </execution> > > >> >>> </executions> > > >> >>> </plugin> > > >> >>> > > >> >>> I get this error : > > >> >>> > > >> >>> [INFO] > > > > >> >>> > ------------------------------------------------------------------------ > > >> >>> [ERROR] BUILD ERROR > > >> >>> [INFO] > > > > >> >>> > ------------------------------------------------------------------------ > > >> >>> [INFO] There must be a POM in the current working directory for > > the > > >> >> Eclipse > > >> >>> plugin to work. > > >> >>> [INFO] > > > > >> >>> > ------------------------------------------------------------------------ > > >> >>> > > >> >>> The EclispePlugin.validate() method fails on > > >> >>> > > >> >>> if ( executedProject.getFile() == null || > > >> >>> !executedProject.getFile().exists() ) ... > > >> >>> > > >> >>> What is the distinction between "executedProject" and "project" > > from a > > >> >>> plugin point of view ? > > >> >>> This seem to have changed in maven 2.0.9. > > >> >>> > > >> >>> My use case is not really standard, but this may suggest some > > >> >> regression > > >> >>> either in maven 2.0.9 or the eclipse plugin. > > >> >>> > > >> >>> Nicolas > > >> >>> > > >> >>> > > >> >>> 2008/3/28, Richard van Nieuwenhoven <[EMAIL PROTECTED]>: > > >> >>> > > >> >>> > > >> >>> > Hi, > > >> >>> > > > >> >>> > here is my +1 > > >> >>> > > > >> >>> > Thanks for the fast release! > > >> >>> > > > >> >>> > Ritchie > > >> >>> > > > >> >>> > Arnaud HERITIER wrote: > > >> >>> > > Hi, > > >> >>> > > > > >> >>> > > Since the 2.5 release we did 10 days ago, we solved 3 > > annoying > > >> >> issues: > > >> >>> > > * [MECLIPSE-266] - plugin applies java facet to ear > > project > > >> >>> > > * [MECLIPSE-411] - manifest property usage is only for > > ogsi > > >> >> maifests > > >> >>> > > * [MECLIPSE-413] - EclipseOSGiManifestWriter uses the > > artifact > > >> >> id > > >> >>> > > and not the EclipseProjectName > > >> >>> > > We also added a new feature : > > >> >>> > > * [MECLIPSE-405] - to-maven target should allow to strip > > >> >> qualifier > > >> >>> > > when creating artifacts from osgi bundles > > >> >>> > > > > >> >>> > > There are still a lot of issues left in JIRA : > > >> >>> > > > > >> >>> > > > >> >> > > > http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11133&status=1 > > >> >>> > > > > >> >>> > > Staging repo : > > >> >>> > > http://people.apache.org/~aheritier/stage/repo/ > > >> >>> > > > > >> >>> > > Staging site (I'm uploading it) : > > >> >>> > > http://maven.apache.org/plugins/maven-eclipse-plugin-2.5.1/ > > >> >>> > > > > >> >>> > > Guide to testing staged releases: > > >> >>> > > > > >> >> > > http://maven.apache.org/guides/development/guide-testing-releases.html > > >> >>> > > > > >> >>> > > Vote open for 5 days. I'll be back on wednesday to do the > > release > > >> >> if > > >> >>> > > the vote passes. > > >> >>> > > > > >> >>> > > [ ] +1 > > >> >>> > > [ ] +0 > > >> >>> > > [ ] -1 > > >> >>> > > > > >> >>> > > > >> >>> > > > >> >>> > > > --------------------------------------------------------------------- > > >> >>> > To unsubscribe, e-mail: [EMAIL PROTECTED] > > >> >>> > For additional commands, e-mail: [EMAIL PROTECTED] > > >> >>> > > > >> >>> > > > >> >>> > > >> >> > > >> >> > > >> >> > > >> >> -- > > >> >> .......................................................... > > >> >> > > >> >> Arnaud HERITIER > > >> >> .......................................................... > > >> >> OCTO Technology - aheritier AT octo DOT com > > >> >> www.octo.com | blog.octo.com > > >> >> .......................................................... > > >> >> ASF - aheritier AT apache DOT org > > >> >> www.apache.org | maven.apache.org > > >> >> ........................................................... > > >> >> > > >> >> > > >> >> > > --------------------------------------------------------------------- > > >> >> To unsubscribe, e-mail: [EMAIL PROTECTED] > > >> >> For additional commands, e-mail: [EMAIL PROTECTED] > > >> >> > > >> >> > > >> > > > >> > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > > >> For additional commands, e-mail: [EMAIL PROTECTED] > > >> > > >> > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > -- .......................................................... Arnaud HERITIER .......................................................... OCTO Technology - aheritier AT octo DOT com www.octo.com | blog.octo.com .......................................................... ASF - aheritier AT apache DOT org www.apache.org | maven.apache.org ........................................................... --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
