I thought he said it was AbstractWagon that had changed, which may
provide protected methods, etc. that aren't in the interfaces...
At any rate, I think I agree with Benjamin, that we should try to
limit (or reduce) the number of AbstractThing super-classes that are
forced into the system by Maven. IMO, AbstractMojo is a problem
waiting to happen...I believe this to the point where, when I write
new plugins, they almost always implement Mojo instead of extending
AbstractMojo, just to try to future-proof them. These abstract
classes have been a real problem lately (thinking about the 2.0.9
release and maven reporting, specifically).
In short, I'm +1 for separating them into -api and -impl, and keeping
abstract classes meant for third-party extension out of maven.
-john
On May 14, 2008, at 10:32 AM, Brian E. Fox wrote:
If we are filtering the interface from classloading...and the
interface
has changed, how does that enable the wagons to work with old Mavens?
Are you saying that the changes are backwards compatible already?
-----Original Message-----
From: Brett Porter [mailto:[EMAIL PROTECTED]
Sent: Wednesday, May 14, 2008 8:29 AM
To: Maven Developers List
Subject: wagon API upgrades
Hi,
I'm running through the issues in Wagon to get towards another
release. On trunk there are already a couple of changes to the
AbstractWagon. In doxia-like fashion, this prevents being able to use
a new wagon with existing versions of Maven, because they use code in
AbstractWagon (which is hidden by Maven via provider-api).
The options then are
- to push these implementation changes into a new module (thinning the
API down do just the interfaces) that is not filtered by Maven
- require a new version of Maven that updates the wagon api and/or
filters only the interfaces from classloading
Given that the first is a bit of an obtuse separation for this
purpose, and that the current providers have been stable for a year
and a half - I'm opting for the second one.
Any other thoughts on this?
- Brett
--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---
John Casey
Committer and PMC Member, Apache Maven
mail: jdcasey at commonjava dot org
blog: http://www.ejlife.net/blogs/john
rss: http://feeds.feedburner.com/ejlife/john
