I haven't reviewed the patch, but the comments by Eric about what he
did sound quite reasonable to me.
Off the top of my head, the rules for this behaviour would be:
- use the POM found in relativePath (default, ../pom.xml) first
- if checked out independantly, use RELEASE
- ensure that when deployed to the repository, it is *always* set. A
POM in the repository with a versionless-parent would be considered
invalid (this is the most likely to break something, since existing
tools might expect that copying pom.xml is valid)
- it would be best if the release plugin also populated, then
unpopulated the version so that on the source tag it is deterministic
(but on trunk, it is convenient).
We don't want to get too magic here - the trend in Maven is towards
specifying more, not less - as the long run benefits outweight the
short term cost. However, in this case - utilising a property of the
source control structure while not relying on it sounds like a good
idea to me.
Cheers,
Brett
On 12/06/2008, at 11:47 AM, Dan Fabulich wrote:
MNG-624 (automatic parent versioning) is far and away the most
popular MNG issue with 85 votes (the next highest has 57).
In June of last year, Jason evaluated the attached patch and found
problems with it, but the problems weren't specified in the bug
description.
Can we revive discussion of this bug? What's wrong with its patch?
-Dan
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
