Brett Porter wrote:
That said, this solution does sound a bit heavy handed. Even though we have a bunch of ITs, something about this feels like it might break something else. Do you have any thoughts on areas of risk outside what the ITs already cover?
I'd say the places currently most at risk are in resource configurations that could be _modified_ by a plugin (not added or removed, but with new or changed includes/excludes/targetPath), and possibly the ordering of filter file declarations. Also, currently plugin configurations are effectively read-only from the perspective of a plugin execution, since they are not back-propagated. Same thing with extensions.
The only other anomalous behavior I've seen has to do with unaligning directories after they come back from a plugin execution...I could see that being expressed one way by the user, then converted to an absolute path for plugin execution, only to be reinterpreted as another non-absolute path afterward...though the two paths (before and after) should be equivalent at that point, I could imagine that subsequent changes could cause them to diverge.
I *think* I've got most of the test cases covered either by integration test (I think there are only three) or by unit test, but the above cases may not be handled adequately.
-john -- John Casey Developer, PMC Member - Apache Maven (http://maven.apache.org) Blog: http://www.ejlife.net/blogs/buildchimp/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
