OK, it is still broken and we really need to have a look to this. I am pretty sure we will break the backward compat if we want to have a consistent behavior. The related issues are MRESOURCES-20 and MWAR-133. I have an IT for MWAR-133 and it uses the maven filtering component. I will have a look now to add an IT because the error does not get revealed with a simple unit test. A quick look on MRESOURCES-20 reveals that applying the patch would have cause other problem so we may need to discuss this a bit more. Any feedback is appreciated
S. On Sat, Aug 2, 2008 at 8:56 AM, Stephane Nicoll <[EMAIL PROTECTED]>wrote: > This should have been fixed now we use the shared filtering component that > Olivier made. I can write an IT to validate the scenario and I will do today > or tomorrow. In any case, we need a release of the filtering component. I am > also waiting for this release to finalize the ear plugin 2.3.2. > Thanks, > Stéphane > > > On Sat, Aug 2, 2008 at 5:36 AM, Wendy Smoak <[EMAIL PROTECTED]> wrote: > >> MWAR-133 (Filtering issue: wrong replacement of properties by values >> from MavenProject object) was mentioned when I asked about releasing >> the war plugin. It has 11 votes and there is a patch attached. Does >> anyone have time to review it? >> >> If this is not fixed before the next release, should the plugin stay at >> alpha? >> >> http://jira.codehaus.org/browse/MWAR-133 >> >> Thanks, >> -- >> Wendy >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > > > -- > Large Systems Suck: This rule is 100% transitive. If you build one, you > suck" -- S.Yegge > -- Large Systems Suck: This rule is 100% transitive. If you build one, you suck" -- S.Yegge
