This isn't the entire reactor, but the getClasspathElements()
method. The only situation I can think of this breaking is:
* someone trying to pull apart the classpath looking for directories
and doing something special with them (which would be a horrible
abuse of the method's contract)
* someone modifying the outputDirectory after packaging and
expecting those changes to stick (a more realistic scenario but
still one that seems unwise to support)
It would seem more important to support the case of modifications to
the final artifact that are not reflected in the target/classes
directory (essentially what shade does, but others may as well). Not
terribly important, but this could still be a change that suits a
2.1+ release IMO.
Yes, any change like is beyond the scope of 2.0.x.
As for shade, to make it work in the reactor, there's 3 options:
Trying to use the shade plugin from the reactor is a misuse of the
plugin. I specifically made it to work with JARs and it reads
entries from JARs.
I'm not quite sure what you mean here. The shade plugin is replacing
the main artifact with the one it produced, but not reflecting that
change in the reactor so others are not using. This is the default
mode for the shade plugin, not some obscure use case.
This was not the primary use case of the shade plugin i.e. replacing
the primarily artifact. The internal logic in 2.0.x is too confused to
try and deal with this case. The shade plugin was specifically made to
create final output after everything else was done. Really a JAR
assembly with the ability to internally rewrite some class references.
I would suggest treating the über JAR like an assembly where you
have a separate project.
That's what I've recommended in the mean time.
Thanks,
Brett
--
Brett Porter
[email protected]
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
jason at sonatype dot com
----------------------------------------------------------
happiness is like a butterfly: the more you chase it, the more it will
elude you, but if you turn your attention to other things, it will come
and sit softly on your shoulder ...
-- Thoreau
