Brett Porter wrote:

Didn't notice that one in there at the time.

Not surprising given the few tests we have ;-). I was already wondering whether we should create some index/text file that groups the existing ITs into categories (e.g. dependency resolution, lifecycle, interpolation) to get a quicker overview of what features are tested or not and if where they are tested.

I think we can remove the 2097 IT with this - the only extra thing it tests is the ability to run that phase from the command line. WDYT?

+1 to remove the standalone IT for 2097 in favor of it0144, you were just quicker to ask. ITs are a powerful but rather expensive means of testing so I believe it is important to test individual features like the lifecycle with one comprehensive test instead of having many small tests which check only sub parts like individual phases.

As for the CLI invocation part of the 2097 IT: The other IT invokes three phases from the CLI (clean, deploy and site-deploy). Assuming that there is no special treatment for other phases in the core code, I personally feel quite comfortable if we do not explicitly check that another phase like "prepare-package" can be invoked from CLI as well.


Benjamin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to