Hi, All Maven subprojects respect (AFAIK) the common directory structure [1] of Maven. IMHO Maven sell speech is about convention, and Maven should be the first place where it would be applied. There is nothing about properties files in our convention [2], but I suggest to revert these changes to respect our lazy convention.
Also, I notified that some static final variables are not in upper case (ie AbstractAntTask) like defined in [2]. I know that Hervé tried to fix them. Could you take care of it in the future? Finally, I saw that all private variables start with a low line. I already used this rule in the past and I like this idea, but Maven projects don't use it. If you think that our convention [2] should be improved feel free to ask on dev@ Cheers, Vincent [1] http://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html [2] http://maven.apache.org/developers/conventions/code.html ---------- Forwarded message ---------- From: [email protected] <[email protected]> Date: 24 déc. 2008 00:56 Subject: svn commit: r729238 - in /maven/mercury/trunk: mercury-ant/mercury-ant-tasks/src/main/java/org/apache/maven/mercury/ant/tasks/ mercury-ant/mercury-ant-tasks/src/main/resources/org/apache/maven/mercury/ant/tasks/ mercury-artifact/src/main/java/org/apach... To: [email protected] Author: ogusakov Date: Tue Dec 23 21:56:45 2008 New Revision: 729238 URL: http://svn.apache.org/viewvc?rev=729238&view=rev Log: refactoring to simplify directory structure Added: maven/mercury/trunk/mercury-ant/mercury-ant-tasks/src/main/java/org/apache/maven/mercury/ant/tasks/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-ant/mercury-ant-tasks/src/main/resources/org/apache/maven/mercury/ant/tasks/Messages.properties maven/mercury/trunk/mercury-artifact/src/main/java/org/apache/maven/mercury/artifact/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-artifact/src/main/resources/org/apache/maven/mercury/artifact/Messages.properties maven/mercury/trunk/mercury-artifact/src/main/java/org/apache/maven/mercury/artifact/version/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-artifact/src/main/resources/org/apache/maven/mercury/artifact/version/Messages.properties maven/mercury/trunk/mercury-event/src/main/java/org/apache/maven/mercury/event/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-event/src/main/resources/org/apache/maven/mercury/event/Messages.properties maven/mercury/trunk/mercury-md/mercury-md-sat/src/main/java/org/apache/maven/mercury/metadata/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-md/mercury-md-sat/src/main/resources/org/apache/maven/mercury/metadata/Messages.properties maven/mercury/trunk/mercury-md/mercury-md-sat/src/main/java/org/apache/maven/mercury/metadata/sat/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-md/mercury-md-sat/src/main/resources/org/apache/maven/mercury/metadata/sat/Messages.properties maven/mercury/trunk/mercury-plexus/src/main/java/org/apache/maven/mercury/plexus/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-plexus/src/main/resources/org/apache/maven/mercury/plexus/Messages.properties maven/mercury/trunk/mercury-repo/mercury-repo-api/src/main/java/org/apache/maven/mercury/repository/api/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-repo/mercury-repo-api/src/main/resources/org/apache/maven/mercury/repository/api/Messages.properties maven/mercury/trunk/mercury-repo/mercury-repo-cache-fs/src/main/java/org/apache/maven/mercury/repository/cache/fs/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-repo/mercury-repo-cache-fs/src/main/resources/org/apache/maven/mercury/repository/cache/fs/Messages.properties maven/mercury/trunk/mercury-repo/mercury-repo-local-flat/src/main/java/org/apache/maven/mercury/repository/local/flat/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-repo/mercury-repo-local-flat/src/main/resources/org/apache/maven/mercury/repository/local/flat/Messages.properties maven/mercury/trunk/mercury-repo/mercury-repo-local-m2/src/main/java/org/apache/maven/mercury/repository/local/m2/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-repo/mercury-repo-local-m2/src/main/resources/org/apache/maven/mercury/repository/local/m2/Messages.properties maven/mercury/trunk/mercury-repo/mercury-repo-remote-m2/src/main/java/org/apache/maven/mercury/repository/remote/m2/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-repo/mercury-repo-remote-m2/src/main/resources/org/apache/maven/mercury/repository/remote/m2/Messages.properties maven/mercury/trunk/mercury-repo/mercury-repo-virtual/src/main/java/org/apache/maven/mercury/repository/virtual/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-repo/mercury-repo-virtual/src/main/resources/org/apache/maven/mercury/repository/virtual/Messages.properties maven/mercury/trunk/mercury-transport/mercury-transport-http/src/main/java/org/apache/maven/mercury/transport/http/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-transport/mercury-transport-http/src/main/resources/org/apache/maven/mercury/transport/http/Messages.properties maven/mercury/trunk/mercury-util/src/main/java/org/apache/maven/mercury/util/Messages.properties - copied unchanged from r729237, maven/mercury/trunk/mercury-util/src/main/resources/org/apache/maven/mercury/util/Messages.properties Removed: maven/mercury/trunk/mercury-ant/mercury-ant-tasks/src/main/resources/org/apache/maven/mercury/ant/tasks/Messages.properties maven/mercury/trunk/mercury-artifact/src/main/resources/org/apache/maven/mercury/artifact/Messages.properties maven/mercury/trunk/mercury-artifact/src/main/resources/org/apache/maven/mercury/artifact/version/Messages.properties maven/mercury/trunk/mercury-event/src/main/resources/org/apache/maven/mercury/event/Messages.properties maven/mercury/trunk/mercury-md/mercury-md-sat/src/main/resources/org/apache/maven/mercury/metadata/Messages.properties maven/mercury/trunk/mercury-md/mercury-md-sat/src/main/resources/org/apache/maven/mercury/metadata/sat/Messages.properties maven/mercury/trunk/mercury-plexus/src/main/resources/org/apache/maven/mercury/plexus/Messages.properties maven/mercury/trunk/mercury-repo/mercury-repo-api/src/main/resources/org/apache/maven/mercury/repository/api/Messages.properties maven/mercury/trunk/mercury-repo/mercury-repo-cache-fs/src/main/resources/org/apache/maven/mercury/repository/cache/fs/Messages.properties maven/mercury/trunk/mercury-repo/mercury-repo-local-flat/src/main/resources/org/apache/maven/mercury/repository/local/flat/Messages.properties maven/mercury/trunk/mercury-repo/mercury-repo-local-m2/src/main/resources/org/apache/maven/mercury/repository/local/m2/Messages.properties maven/mercury/trunk/mercury-repo/mercury-repo-remote-m2/src/main/resources/org/apache/maven/mercury/repository/remote/m2/Messages.properties maven/mercury/trunk/mercury-repo/mercury-repo-virtual/src/main/resources/org/apache/maven/mercury/repository/virtual/Messages.properties maven/mercury/trunk/mercury-transport/mercury-transport-http/src/main/resources/org/apache/maven/mercury/transport/http/Messages.properties maven/mercury/trunk/mercury-util/src/main/resources/org/apache/ --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
