Hi Vincent,

Why not using AbstractMavenReport#closeReport() instead of?

All the maven-reporting-impl versions I have looked at work like this:

    public void generate( ... )
        throws MavenReportException
    {
        ...

        executeReport( aLocale );

        closeReport();
    }

Note that closeReport() is happily skipped here if an exception occurs during executeReport() :(

It might be the desired behavior for closeReport() to be only called after a successful report generation (the javadoc doesn't tell) but at least the sink needs to be closed even in case of abnormal report termination.

I haven't looked deeper yet but eventually the sink should be closed by its creator (Doxia, Site Plugin?).


Benjamin


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to